support veth link type#28
Merged
Merged
Conversation
Introduce veth (virtual ethernet) interface support for both creation and query. Usage: ip link add NAME type veth peer PEER_NAME The peer name is parsed from iface_specific. The display path extracts the peer name from InfoVeth::Peer LinkMessage attributes and shows it as 'peer <name>' in detailed output. Integration tests cover basic show, detailed show, JSON show, and detailed JSON show. Signed-off-by: Gris Ge <cnfourt@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for veth (Virtual Ethernet) interfaces, including the ability to add links, serialize veth-specific data, and display it in the CLI. Integration tests for veth functionality were also added. Feedback includes a recommendation to validate that no unexpected trailing arguments are provided after the peer name in apply_veth and a suggestion to remove a redundant interface deletion in the test cleanup logic, as deleting one end of a veth pair automatically removes the other.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce veth (virtual ethernet) interface support for both creation
and query. Usage:
ip link add NAME type veth peer PEER_NAME
The peer name is parsed from iface_specific. The display path extracts
the peer name from InfoVeth::Peer LinkMessage attributes and shows it
as 'peer ' in detailed output.
Integration tests cover basic show, detailed show, JSON show, and
detailed JSON show.