ip link: add hsr type support#32
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds support for High-availability Seamless Redundancy (HSR) network interfaces, including configuration, display, and integration tests. It also generalizes the link resolution logic from VxLAN-specific to a generic link resolver. The review feedback suggests several code quality improvements: optimizing string allocation in resolve_link using unwrap_or_else, removing redundant local variables in CliLinkInfoDataHsr::from, and updating a code comment to reflect the generalized link resolution.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Introduced `ip link add type hsr` command and `ip link show hsr` display. Supported arguments: slave1 (required), slave2 (required), interlink, supervision, version, proto. Integration test case included to verify creation and detailed show output match iproute2. Signed-off-by: Gris Ge <cnfourt@gmail.com>
Introduced
ip link add type hsrcommand andip link show hsrdisplay.
Supported arguments: slave1 (required), slave2 (required), interlink,
supervision, version, proto.
Integration test case included to verify creation and detailed show
output match iproute2.