Improve the implementation of Burnikel-Ziegler division#350
Merged
Conversation
cuviper
commented
Jul 6, 2026
cuviper
commented
Member
- Use a block size based on the divisor rather than the dividend
- This corresponds to the paper's Algorithm 3
- Normalize the divisor just once, avoiding the Knuth shifts as well
- Use a block size based on the divisor rather than the dividend - This corresponds to the paper's Algorithm 3 - Normalize the divisor just once, avoiding the Knuth shifts as well
Member
Author
|
I think there's still room to improve, especially avoiding allocations, but so far that's not showing up much in perf profiles. I guess it reduces to the smaller algorithms well enough, and otherwise it depends mostly on multiplication. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.