Conversation
| #![cfg_attr(feature = "f16", feature(f16))] | ||
| #![cfg_attr(feature = "f128", feature(f128))] |
There was a problem hiding this comment.
I'm not keen on maintaining for unstable features in this crate, so we're probably going to be blocked here until the language and standard library stabilize these new floats.
At that point, I think we'll probably want to have detection in the build script to enable it automatically, and Cargo features can force that on -- like we used to for has_i128.
c6e7689 to
dc38e4d
Compare
510dfa4 to
3deee50
Compare
|
rust-lang/libs-team#707 would eventually rely on this (as per my implementation) so could we expedite support? |
I would not expect the standard library to start using (My reservations remain about unstable features as well.) |
|
Trying this again, though I think the reservations about unstable features are valid: We're aiming to stabilize For testing I'd propose to use cargo features, similar to what I implemented for The |
|
For testing purposes, you could just |
61b3add to
37f3fce
Compare
integer_decodeis implemented forf128by truncating the radix to its 64 most significant bits. See Float::integer_decode cannot be implemented for quadruple precision floating types. #98.no_stdandlibm, and a test fail because of this.