Skip to content

Commit bdbd25f

Browse files
PelleKrabnicholasbishop
authored andcommitted
chore(comments): Removed verbose comments
1 parent 9ba1d62 commit bdbd25f

1 file changed

Lines changed: 0 additions & 5 deletions

File tree

build-edk2/Dockerfile

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,6 @@ RUN git clone https://github.com/tianocore/edk2-platforms.git /edk2-platforms &&
3838
cd /edk2-platforms && \
3939
git checkout 1e64c1109ae2ac0185351e8d0c19732970d4fecf
4040

41-
# Create symbolic links to make IntelSiliconPkg accessible from edk2 workspace
42-
# The INF files reference both Silicon/Intel/IntelSiliconPkg and IntelSiliconPkg paths
4341
RUN ln -s /edk2-platforms/Silicon /edk2/Silicon && \
4442
ln -s /edk2-platforms/Silicon/Intel/IntelSiliconPkg /edk2/IntelSiliconPkg
4543

@@ -49,11 +47,9 @@ RUN . venv/bin/activate && pip install -r pip-requirements.txt --upgrade
4947
ENV toolchain=GCC5
5048
RUN . venv/bin/activate && python BaseTools/Edk2ToolsBuild.py -t "${toolchain}"
5149

52-
# Add IntelVTdDxe to OvmfPkgX64.dsc (for compilation)
5350
RUN sed -i '/\[Components\]/a \ Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/IntelVTdDxe.inf' \
5451
/edk2/OvmfPkg/OvmfPkgX64.dsc
5552

56-
# Add IntelVTdDxe to OvmfPkgX64.fdf (for inclusion in firmware image)
5753
# Place after AcpiTableDxe since VTdDxe depends on ACPI tables (DMAR)
5854
RUN sed -i '/INF MdeModulePkg\/Universal\/Acpi\/AcpiTableDxe\/AcpiTableDxe.inf/a \ INF Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/IntelVTdDxe.inf' \
5955
/edk2/OvmfPkg/OvmfPkgX64.fdf
@@ -75,7 +71,6 @@ ENV stuart_opts="-c OvmfPkg/PlatformCI/QemuBuild.py -a RISCV64 Target=${build_ta
7571
RUN . venv/bin/activate && stuart_setup ${stuart_opts} && stuart_update ${stuart_opts} && stuart_build ${stuart_opts}
7672

7773
# Build X64.
78-
# Set PACKAGES_PATH as an ENV variable that persists through all stuart commands
7974
ENV PACKAGES_PATH="/edk2:/edk2-platforms"
8075
ENV stuart_opts="-c OvmfPkg/PlatformCI/PlatformBuild.py -a X64 Target=${build_target} TOOL_CHAIN_TAG=${toolchain} ${common_build_opt} ${tpm_build_opt}"
8176
RUN . venv/bin/activate && stuart_setup ${stuart_opts} && stuart_update ${stuart_opts} && stuart_build ${stuart_opts}

0 commit comments

Comments
 (0)