Upstream rand_core release broke this package

[karalabe]

error[E0432]: unresolved import `rand_core::TryRngCore`
 --> /Users/karalabe/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/getrandom-0.4.0-rc.0/src/sys_rng.rs:2:31
  |
2 | use rand_core::{TryCryptoRng, TryRngCore};
  |                               ^^^^^^^^^^ no `TryRngCore` in the root

error[E0277]: the trait bound `SysRng: TryRng` is not satisfied
   --> /Users/karalabe/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/getrandom-0.4.0-rc.0/src/sys_rng.rs:54:23
    |
 54 | impl TryCryptoRng for SysRng {}
    |                       ^^^^^^ unsatisfied trait bound
    |
help: the trait `DerefMut` is not implemented for `SysRng`
   --> /Users/karalabe/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/getrandom-0.4.0-rc.0/src/sys_rng.rs:33:1
    |
 33 | pub struct SysRng;
    | ^^^^^^^^^^^^^^^^^
    = help: the trait `TryRng` is implemented for `UnwrapErr<R>`
    = note: required for `SysRng` to implement `TryRng`
note: required by a bound in `TryCryptoRng`
   --> /Users/karalabe/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rand_core-0.10.0-rc-6/src/lib.rs:243:25
    |
243 | pub trait TryCryptoRng: TryRng {}
    |                         ^^^^^^ required by this bound in `TryCryptoRng`

Some errors have detailed explanations: E0277, E0432.
For more information about an error, try `rustc --explain E0277`.
error: could not compile `getrandom` (lib) due to 2 previous errors

[dhardy]

This should have already been resolved: #787.

[tarcieri]

@karalabe this is, I hope, the last breaking change before a stable v0.10 release, which should ideally also be the last breaking change before a v1

[dhardy]

@karalabe I would guess that you're seeing this message because the RustCrypto crates do not pin pre-release versions and you ended up using incompatible packages.

You can work around this on your end using cargo update --precise to roll back to a previous release of rand_core.

@tarcieri I'm still not convinced that not pinning pre-release versions is the better option, but your call I guess.

[tarcieri]

Not pinning is what lets us do quick turnarounds getting everything compatible again. We should have compatible versions of everything out in a few hours.

[karalabe]

error[E0432]: unresolved import `rand_core::TryRngCore`
  --> /Users/karalabe/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/ml-kem-0.3.0-pre.4/src/kem.rs:21:42
   |
21 | use rand_core::{CryptoRng, TryCryptoRng, TryRngCore};
   |                                          ^^^^^^^^^^ no `TryRngCore` in the root

For more information about this error, try `rustc --explain E0432`.
error: could not compile `ml-kem` (lib) due to 1 previous error

[tarcieri]

@karalabe I'm close, onto elliptic-curve, then ecdsa, then the elliptic curve crates, then I can fix dhkem: RustCrypto/traits#2233

[karalabe]

Appreciate it, just wanted to poke you a bit to maybe reconsider the pinning approach. I most definitely will pin all the libs in my next release to avoid this in the future.

[tarcieri]

We pinned when we did the .pre development, it turned into dependency hell, if things were pinned I would be a fraction of where I am now upgrading things. It's just too big of a dependency graph for that to be practical.

How about checking in Cargo.lock? 😉

[dhardy]

@karalabe like this: rust-random/rngs#93

But yes, in an ideal world that wouldn't be necessary.