Add release.yml CI action#740
Conversation
|
Added code from https://medium.com/@usman_qb/from-git-tag-to-github-release-automating-changelog-extraction-9cfcad1b13c4 (modified slightly due to our tag format). I don't know how to test this other than to make a release. |
897c11e to
990f1a5
Compare
| - name: Create release body | ||
| id: create_release_body | ||
| run: | | ||
| RELEASEVERSION="[${{ '[' + github.ref_name.slice(1) + ']' }}]" |
There was a problem hiding this comment.
Assumption: we can evaluate JavaScript here. GH docs seem to imply this.
|
I believe this should work as intended, or at least not cause problems:
Testing needed, somewhere. |
|
LGTM on the first glance, but note that I do not have experience of using Trusted Publishing. |
|
Me neither, and while not giving GH Actions long-lived tokens is a good thing, this still fundamentally gives Actions the ability to publish crates. Whether or not we want that is another question. (My main motivation here was exploring possibilities. It may be that we want the GH release stuff but not the crates.io publishing.) What I do like is that this approach associates crates.io releases with git tags (assuming one does not publish to crates.io first). |
|
Closing: #748 replaces the crates.io part; the GH part is trickier and should probably use a separate job (refer to our experiments with https://github.com/rust-random/core/). |
This is the repo-side configuration of https://crates.io/docs/trusted-publishing