Skip to content

Bump wasip3 to v0.4 #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
newpavlov merged 5 commits into from
Jan 26, 2026
+113 −59
Merged

Bump wasip3 to v0.4 #790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
519b34f
Bump `wasip3` to v0.4
newpavlov Jan 26, 2026
c9a3dac
Bump Rust to 1.87 for WASIp2 CI job
newpavlov Jan 26, 2026
1ddc9df
Remove `default-features = false` for wasip3
newpavlov Jan 26, 2026
a7b42a5
Fix MSRV job for WASIp2
newpavlov Jan 26, 2026
b229df2
fix CI config
newpavlov Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .cargo/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,12 @@ runner = 'wasm-bindgen-test-runner'
runner = 'wasmtime'
[target.wasm32-wasip2]
runner = 'wasmtime'
[target.wasm32-wasip3]
runner = 'wasmtime'

# Just run on node by default (that's where emscripten is tested)
[target.'cfg(target_os = "emscripten")']
runner = 'node'

[resolver]
incompatible-rust-versions = "allow"
Copy link
Copy Markdown
Member Author

@newpavlov newpavlov Jan 26, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasip3 v0.4 requires Rust 1.87. Technically, we should bump rust-version for getrandom as well, but I guess it's fine to skip it in this case.

Unfortunately, this setting may complicate MSRV testing since we could pull dependencies into Cargo.lock which require a higher Rust version. I think the right way to handle this would be to execute cargo update in each MSRV job.

Copy link
Copy Markdown
Member

@dhardy dhardy Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it not sufficient to use cargo update --ignore-rust-version only in the relevant tests?

Copy link
Copy Markdown
Member Author

@newpavlov newpavlov Jan 26, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it could work as well. But I think we should commit latest dependency versions into Cargo.lock and test with them by default, not MSRV-compatible ones. Plus, we have more non-MSRV jobs.

Copy link
Copy Markdown
Member Author

@newpavlov newpavlov Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See

getrandom/.github/workflows/tests.yml

Lines 373 to 376 in b229df2

- name: Generate MSRV-compatible Cargo.lock
env:
CARGO_RESOLVER_INCOMPATIBLE_RUST_VERSIONS: "fallback"
run: cargo update

4 changes: 4 additions & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,10 @@ jobs:
wget -O - $URL | tar -xJ --strip-components=1 -C ~/.cargo/bin
wasmtime --version
- uses: Swatinem/rust-cache@v2
- name: Generate MSRV-compatible Cargo.lock
env:
CARGO_RESOLVER_INCOMPATIBLE_RUST_VERSIONS: "fallback"
run: cargo update
Copy link
Copy Markdown
Contributor

@briansmith briansmith Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it would be better to restrict this to -p wasip2 -p wasip3 or whatever, instead of updating all the dependencies.

- run: cargo test --target wasm32-wasip2

# TODO: enable after pre-built std will be provided by Rust
Expand Down
Loading