Skip to content

Deprecate rand_isaac #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhardy merged 2 commits into from
May 20, 2026
Merged

Deprecate rand_isaac #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4a6225
Deprecate rand_isaac
dhardy May 19, 2026
0fb49c8
Remove rand_isaac from benches
dhardy May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 7 additions & 15 deletions benches/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion benches/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ criterion-cycles-per-byte = "0.6"
rand_core = "0.10.0"
rand_chacha = { path = "../rand_chacha", version = "0.10.0-rc.6" }
rand_xoshiro = { path = "../rand_xoshiro", version = "0.8.0-rc.0" }
rand_isaac = { path = "../rand_isaac", version = "0.5.0-rc.0" }
rand_xorshift = { path = "../rand_xorshift", version = "0.5.0-rc.0" }
rand_hc = { path = "../rand_hc", version = "0.5.0-rc.0" }
rand_sfc = { path = "../rand_sfc", version = "0.2.0-rc.0" }
Expand Down
9 changes: 0 additions & 9 deletions benches/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ use rand_core::{Rng, SeedableRng};

use rand_chacha::{ChaCha8Rng, ChaCha12Rng, ChaCha20Rng};
use rand_hc::Hc128Rng;
use rand_isaac::{Isaac64Rng, IsaacRng};
use rand_sfc::{Sfc32, Sfc64};
use rand_xorshift::XorShiftRng;
use rand_xoshiro::{
Expand Down Expand Up @@ -84,8 +83,6 @@ fn gen_bytes(c: &mut Criterion<CyclesPerByte>) {
gen_bytes!("xoroshiro64star", Xoroshiro64Star::from_rng(&mut master));
gen_bytes!("splitmix64", SplitMix64::from_rng(&mut master));
gen_bytes!("hc128", Hc128Rng::from_rng(&mut master));
gen_bytes!("isaac", IsaacRng::from_rng(&mut master));
gen_bytes!("isaac64", Isaac64Rng::from_rng(&mut master));
gen_bytes!("sfc32", Sfc32::from_rng(&mut master));
gen_bytes!("sfc64", Sfc64::from_rng(&mut master));
gen_bytes!("chacha8", ChaCha8Rng::from_rng(&mut master));
Expand Down Expand Up @@ -197,8 +194,6 @@ fn gen_uint(c: &mut Criterion<CyclesPerByte>) {
);
gen_uint!(g, "splitmix64", u32, SplitMix64::from_rng(&mut master));
gen_uint!(g, "hc128", u32, Hc128Rng::from_rng(&mut master));
gen_uint!(g, "isaac", u32, IsaacRng::from_rng(&mut master));
gen_uint!(g, "isaac64", u32, Isaac64Rng::from_rng(&mut master));
gen_uint!(g, "sfc32", u32, Sfc32::from_rng(&mut master));
gen_uint!(g, "sfc64", u32, Sfc64::from_rng(&mut master));
gen_uint!(g, "chacha8", u32, ChaCha8Rng::from_rng(&mut master));
Expand Down Expand Up @@ -273,8 +268,6 @@ fn gen_uint(c: &mut Criterion<CyclesPerByte>) {
);
gen_uint!(g, "splitmix64", u64, SplitMix64::from_rng(&mut master));
gen_uint!(g, "hc128", u64, Hc128Rng::from_rng(&mut master));
gen_uint!(g, "isaac", u64, IsaacRng::from_rng(&mut master));
gen_uint!(g, "isaac64", u64, Isaac64Rng::from_rng(&mut master));
gen_uint!(g, "sfc32", u64, Sfc32::from_rng(&mut master));
gen_uint!(g, "sfc64", u64, Sfc64::from_rng(&mut master));
gen_uint!(g, "chacha8", u64, ChaCha8Rng::from_rng(&mut master));
Expand Down Expand Up @@ -309,8 +302,6 @@ fn init(c: &mut Criterion) {
init_gen!("xoroshiro64star", Xoroshiro64Star);
init_gen!("splitmix64", SplitMix64);
init_gen!("hc128", Hc128Rng);
init_gen!("isaac", IsaacRng);
init_gen!("isaac64", Isaac64Rng);
init_gen!("sfc32", Sfc32);
init_gen!("sfc64", Sfc64);
init_gen!("chacha8", ChaCha8Rng);
Expand Down
5 changes: 5 additions & 0 deletions rand_isaac/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.5.1] - 2026-05-19
Deprecate crate `rand_isaac` ([#113]).

[#113]: https://github.com/rust-random/rngs/pull/113

## [0.5.0] - 2026-02-01
### Value-breaking changes
- Drop use of half-used words in `Isaac64Rng::next_u32` ([#82])
Expand Down
2 changes: 1 addition & 1 deletion rand_isaac/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "rand_isaac"
version = "0.5.0"
version = "0.5.1"
authors = ["The Rand Project Developers", "The Rust Project Developers"]
license = "MIT OR Apache-2.0"
readme = "README.md"
Expand Down
4 changes: 4 additions & 0 deletions rand_isaac/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@
clippy::identity_op
)]
#![cfg_attr(not(all(feature = "serde", test)), no_std)]
#![deprecated(
since = "0.5.1",
note = "The rand_isaac crate is no longer maintained; we suggest switching to chacha20 or rand_hc"
)]

pub mod isaac;
pub mod isaac64;
Expand Down
Loading