reinstate commented-out test as an end-to-end test

Author: Shnatsel

cargo-auditable/src/auditable_from_metadata.rs

@@ -237,31 +237,3 @@ fn strongest_dep_kind(deps: &[cargo_metadata::DepKindInfo]) -> PrivateDepKind {
         .max()
         .unwrap_or(PrivateDepKind::Runtime) // for compatibility with Rust earlier than 1.41
 }
-
-#[cfg(test)]
-mod tests {
-    #![allow(unused_imports)] // otherwise conditional compilation emits warnings
-    use super::*;
-    use std::fs;
-    use std::{
-        convert::TryInto,
-        path::{Path, PathBuf},
-        str::FromStr,
-    };
-
-    fn load_metadata(cargo_toml_path: &Path) -> cargo_metadata::Metadata {
-        let mut cmd = cargo_metadata::MetadataCommand::new();
-        cmd.manifest_path(cargo_toml_path);
-        cmd.exec().unwrap()
-    }
-
-    // #[test]
-    // fn dependency_cycle() {
-    //     let cargo_toml_path = PathBuf::from(std::env::var("CARGO_MANIFEST_DIR").unwrap())
-    //         .join("tests/fixtures/cargo-audit-dep-cycle/Cargo.toml");
-    //     let metadata = load_metadata(&cargo_toml_path);
-    //     let version_info_struct: VersionInfo = encode_audit_data(&metadata).unwrap();
-    //     let json = serde_json::to_string(&version_info_struct).unwrap();
-    //     VersionInfo::from_str(&json).unwrap(); // <- the part we care about succeeding
-    // }
-}

cargo-auditable/tests/it.rs

@@ -484,3 +484,18 @@ fn test_dependency_unification() {
         .iter()
         .any(|p| p.name == "optional_transitive_dep"));
 }
+
+#[test]
+fn test_dep_cycle() {
+    // Path to workspace fixture Cargo.toml. See that file for overview of workspace members and their dependencies.
+    let workspace_cargo_toml = PathBuf::from(env!("CARGO_MANIFEST_DIR"))
+        .join("tests/fixtures/cargo-audit-dep-cycle/Cargo.toml");
+    // Run in workspace root with default features
+    let bins = run_cargo_auditable(workspace_cargo_toml, &[], &[]);
+    eprintln!("Test fixture binary map: {bins:?}");
+
+    let toplevel_crate_bin = &bins.get("cargo-audit-dep-cycle").unwrap()[0];
+    // Deserialization checks for cycles, so we only need to verify that it succeeds
+    let dep_info = get_dependency_info(toplevel_crate_bin);
+    eprintln!("{toplevel_crate_bin} dependency info: {dep_info:?}");
+}