kvm-ioctls: Make get/has/set_device_attr available on x86-64#380
Open
rbradford wants to merge 1 commit into
Open
kvm-ioctls: Make get/has/set_device_attr available on x86-64#380rbradford wants to merge 1 commit into
rbradford wants to merge 1 commit into
Conversation
Previously these were only marked as available on aarch64. Signed-off-by: Rob Bradford <rbradford@meta.com>
rbradford
requested review from
ShadowCurse,
acatangiu,
andreeaflorescu,
lauralt,
roypat and
sameo
as code owners
June 19, 2026 15:27
RuoqingHe
approved these changes
Jun 22, 2026
RuoqingHe
left a comment
RuoqingHe
left a comment
Member
There was a problem hiding this comment.
Looks reasonable to me, thanks @rbradford ❤️
| /// let vm = kvm.create_vm().unwrap(); | ||
| /// let vcpu = vm.create_vcpu(0).unwrap(); | ||
| /// | ||
| /// #[cfg(target_arch = "x86_64")] |
Member
There was a problem hiding this comment.
Should we come up with a aarch64 example as well
There was a problem hiding this comment.
I agree, this would be consistent with the rest of the patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously these were only marked as available on aarch64.
Signed-off-by: Rob Bradford rbradford@meta.com
Summary of the PR
These methods on cpu were previously only available on aarch64.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.