Skip to content

EGL: Provide color-space support#1658

Draft
MarijnS95 wants to merge 1 commit into
rust-windowing:masterfrom
MarijnS95:hdr
Draft

EGL: Provide color-space support#1658
MarijnS95 wants to merge 1 commit into
rust-windowing:masterfrom
MarijnS95:hdr

Conversation

@MarijnS95

@MarijnS95 MarijnS95 commented Dec 21, 2023

Copy link
Copy Markdown
Member

Closes #1653

Still a few things to do, such as:

  • writing a commit message;
  • addressing TODOs;
  • deciding where to go with EglSurfaceAttributes since it's so easy to get wrong;
  • Remove unneeded changes from the example.

@MarijnS95
MarijnS95 force-pushed the hdr branch 4 times, most recently from dc2cd57 to 74841c3 Compare December 24, 2023 17:20
Comment thread glutin/src/surface.rs Outdated
Comment thread glutin_egl_sys/build.rs Outdated
Comment thread glutin/src/api/egl/surface.rs
@kchibisov

Copy link
Copy Markdown
Member

Do you want me to look into something specific here given that you have it as a draft and have a bunch of debug in the code?

@MarijnS95

Copy link
Copy Markdown
Member Author

@kchibisov sure the example used to contain a full setup for using EGL HDR color spaces.

As this is "the only" example in glutin I surely feel that shouldn't immediately expose the user to a completely EGL-specific color space setup, especially if we don't even go to lengths to use the right colors in other spaces. I've now dropped that from this PR. If you think we should, I could always reintroduce it as a separate example app (though wouldn't wish to duplicate 90% of the current example... 😅).

This PR still contains some drive-by ideas to make it easier to work with "HDR" surfaces, such as maybe making it more straightforward to create a ConfigTemplateBuilder for different "popular" formats?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Design considerations for HDR colorspace support

2 participants