Skip to content

egl_sys: Drop duplicate manual definition of (EGL_)TEXTURE_FORMAT#1683

Merged
MarijnS95 merged 1 commit into
masterfrom
drop-manual-egl-texture-format-again
Jun 7, 2024
Merged

egl_sys: Drop duplicate manual definition of (EGL_)TEXTURE_FORMAT#1683
MarijnS95 merged 1 commit into
masterfrom
drop-manual-egl-texture-format-again

Conversation

@MarijnS95

Copy link
Copy Markdown
Member

For #1668 (comment)

The generated code already defines TEXTURE_FORMAT to 0x3080 with the usual EGL_ prefix stripped; we shouldn't be redefining it (with this unnecessary prefix) in manual code.

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality

The generated code already defines `TEXTURE_FORMAT` to `0x3080` with the
usual `EGL_` prefix stripped; we shouldn't be redefining it (with this
unnecessary prefix) in manual code.
@MarijnS95

Copy link
Copy Markdown
Member Author

Right above there's a comment:

// Possible values for EGL_TEXTURE_FORMAT.

I'm carefully considering to rename that to glutin_egl_sys::TEXTURE_FORMAT. Thoughts?

@kchibisov

Copy link
Copy Markdown
Member

I know that certain constants in spec have different names, but the same values, the same with e.g. some drm pixel formats, etc, etc. So if both names exist in spec, I won't mind keeping both of them.

@MarijnS95

Copy link
Copy Markdown
Member Author

I think that there's only EGL_TEXTURE_FORMAT. As with everything that's output by gl-generator, the common EGL_ prefix is stripped off, and @chrisduerr in #1668 simply missed that it was already available in the autogenerated bindings? The value is the same too.

@MarijnS95
MarijnS95 merged commit 9d38735 into master Jun 7, 2024
kchibisov pushed a commit that referenced this pull request Jun 8, 2024
…1683)

The generated code already defines `TEXTURE_FORMAT` to `0x3080` with the
usual `EGL_` prefix stripped; we shouldn't be redefining it (with this
unnecessary prefix) in manual code.
@MarijnS95
MarijnS95 deleted the drop-manual-egl-texture-format-again branch June 11, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants