egl_sys: Drop duplicate manual definition of (EGL_)TEXTURE_FORMAT#1683
Merged
Conversation
The generated code already defines `TEXTURE_FORMAT` to `0x3080` with the usual `EGL_` prefix stripped; we shouldn't be redefining it (with this unnecessary prefix) in manual code.
Member
Author
|
Right above there's a comment: // Possible values for EGL_TEXTURE_FORMAT.I'm carefully considering to rename that to |
Member
|
I know that certain constants in spec have different names, but the same values, the same with e.g. some drm pixel formats, etc, etc. So if both names exist in spec, I won't mind keeping both of them. |
Member
Author
|
I think that there's only |
kchibisov
approved these changes
Jun 7, 2024
chrisduerr
approved these changes
Jun 7, 2024
kchibisov
pushed a commit
that referenced
this pull request
Jun 8, 2024
…1683) The generated code already defines `TEXTURE_FORMAT` to `0x3080` with the usual `EGL_` prefix stripped; we shouldn't be redefining it (with this unnecessary prefix) in manual code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #1668 (comment)
The generated code already defines
TEXTURE_FORMATto0x3080with the usualEGL_prefix stripped; we shouldn't be redefining it (with this unnecessary prefix) in manual code.CHANGELOG.mdif knowledge of this change could be valuable to users