breaking: Remove HasRawXHandle traits

This commit removes the HasRawWindowHandle trait as well as the
HasRawDisplayHandle trait. These have been deprecated since version
0.6.0.

Ref: #177
Signed-off-by: John Nunley <dev@notgull.net>

Author: notgull

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 * **Breaking:** Rework web handles to remove `wasm-bindgen` from public API. (#184)
 - **Breaking:** Remove `WebWindowHandle` as it is no longer used. (#186)
+- **Breaking:** Remove deprecated `HasRawWindowHandle` and `HasRawDisplayHandle` traits.
 * Improve documentation on AppKit and UIKit handles.
 * Deprecated `UiKitWindowHandle::ui_view_controller`, retrieve this from the UIView's responder chain instead.
 

src/lib.rs

@@ -60,32 +60,6 @@ pub use windows::{Win32WindowHandle, WinRtWindowHandle, WindowsDisplayHandle};
 
 use core::fmt;
 
-/// Window that wraps around a raw window handle.
-///
-/// # Safety
-///
-/// Users can safely assume that pointers and non-zero fields are valid, and it is up to the
-/// implementer of this trait to ensure that condition is upheld.
-///
-/// Despite that qualification, implementers should still make a best-effort attempt to fill in all
-/// available fields. If an implementation doesn't, and a downstream user needs the field, it should
-/// try to derive the field from other fields the implementer *does* provide via whatever methods the
-/// platform provides.
-///
-/// The exact handles returned by `raw_window_handle` must remain consistent between multiple calls
-/// to `raw_window_handle` as long as not indicated otherwise by platform specific events.
-#[deprecated = "Use `HasWindowHandle` instead"]
-pub unsafe trait HasRawWindowHandle {
-    fn raw_window_handle(&self) -> Result<RawWindowHandle, HandleError>;
-}
-
-#[allow(deprecated)]
-unsafe impl<T: HasWindowHandle + ?Sized> HasRawWindowHandle for T {
-    fn raw_window_handle(&self) -> Result<RawWindowHandle, HandleError> {
-        self.window_handle().map(Into::into)
-    }
-}
-
 /// A window handle for a particular windowing system.
 ///
 /// Each variant contains a struct with fields specific to that windowing system
@@ -202,32 +176,6 @@ pub enum RawWindowHandle {
     Haiku(HaikuWindowHandle),
 }
 
-/// Display that wraps around a raw display handle.
-///
-/// # Safety
-///
-/// Users can safely assume that pointers and non-zero fields are valid, and it is up to the
-/// implementer of this trait to ensure that condition is upheld.
-///
-/// Despite that qualification, implementers should still make a best-effort attempt to fill in all
-/// available fields. If an implementation doesn't, and a downstream user needs the field, it should
-/// try to derive the field from other fields the implementer *does* provide via whatever methods the
-/// platform provides.
-///
-/// The exact handles returned by `raw_display_handle` must remain consistent between multiple calls
-/// to `raw_display_handle` as long as not indicated otherwise by platform specific events.
-#[deprecated = "Use `HasDisplayHandle` instead"]
-pub unsafe trait HasRawDisplayHandle {
-    fn raw_display_handle(&self) -> Result<RawDisplayHandle, HandleError>;
-}
-
-#[allow(deprecated)]
-unsafe impl<T: HasDisplayHandle + ?Sized> HasRawDisplayHandle for T {
-    fn raw_display_handle(&self) -> Result<RawDisplayHandle, HandleError> {
-        self.display_handle().map(Into::into)
-    }
-}
-
 /// A display server handle for a particular windowing system.
 ///
 /// The display usually represents a connection to some display server, but it is not necessarily
@@ -480,11 +428,5 @@ mod tests {
     }
 
     #[allow(deprecated, unused)]
-    fn assert_object_safe(
-        _: &dyn HasRawWindowHandle,
-        _: &dyn HasRawDisplayHandle,
-        _: &dyn HasWindowHandle,
-        _: &dyn HasDisplayHandle,
-    ) {
-    }
+    fn assert_object_safe(_: &dyn HasWindowHandle, _: &dyn HasDisplayHandle) {}
 }