Simplify usage of Context#267
Merged
Merged
Conversation
madsmtm
force-pushed
the
madsmtm/context-easier
branch
from
e2d94d0 to
b97e10e
Compare
ids1024
reviewed
Jun 5, 2025
madsmtm
force-pushed
the
madsmtm/context-easier
branch
from
b97e10e to
831973c
Compare
Member
|
Maybe I wish this PR was split (or at least rebase-merged) in two pieces: it was a bit unclear to figure out that |
Member
Author
|
Yeah, sorry about that. I just kinda merged it because it hadn't gotten any comments for a while. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify creation of
Contextin examples by constructing it before running the event loop with the new-ishEventLoop::owned_display_handle.This PR also makes
ContextClonewhen the inner display handle is, to allow more easily passing it around.