Add Buffer::width() and Buffer::height() getters#269
Merged
Conversation
madsmtm
commented
Jun 5, 2025
madsmtm
commented
Jun 5, 2025
madsmtm
commented
Jun 5, 2025
madsmtm
force-pushed
the
madsmtm/width-height
branch
from
6789eff to
344f8b7
Compare
madsmtm
force-pushed
the
madsmtm/width-height
branch
from
344f8b7 to
3f255f4
Compare
MarijnS95
approved these changes
Nov 22, 2025
Member
MarijnS95
left a comment
MarijnS95
left a comment
There was a problem hiding this comment.
The examples look so much better with this change, no more "hacks" based on a possibly-stale and/or desynced window size.
Approving at least the Android parts; these getters are just fields returned internally.
Co-authored-by: Marijn Suijten <marijns95@gmail.com>
MarijnS95
changed the title
Buffer::width and Buffer::heightBuffer::width() and Buffer::height() getters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #237.
I've decided to return these in pixels corresponding to the surface/buffer itself, as that's what Softbuffer concerns itself with. If the user wants to render at the current screen DPI, they either need to multiply by a scaling factor themselves, or size the buffer using logical sizes and rely on the compositor to upscale it (which we don't yet expose knobs to control, but which we could in the future).