CoreGraphics: Use single-buffering#343
Merged
Merged
Conversation
madsmtm
added
enhancement
ids1024
reviewed
Mar 10, 2026
madsmtm
changed the title
Allows us to get by with a single buffer, since it properly signals us when the buffer is and isn't in use.
madsmtm
force-pushed
the
apple-buffering
branch
from
416b4aa to
d456fa8
Compare
Member
Author
|
I found a way to get a reliable signal from CG for when QuartzCore is reading from the buffer ( |
That seems like a big win. I was onboard with triple buffering if it was required, but that would have been very memory intensive for large surfaces. |
flukejones
added a commit
to flukejones/softbuffer
that referenced
this pull request
Jun 9, 2026
Back the CoreGraphics buffer with an IOSurface instead of CGDataProvider. IOSurface is shared zero-copy with the compositor, avoiding the internal copy QuartzCore did on present. - keep single-buffer model; block on `is_in_use` in next_buffer before writing, since the compositor reads the surface directly (no internal copy to rely on) - stride uses surface.bytes_per_row (may be padded for alignment) - present sets CALayer.contents to the IOSurface, disabling actions to avoid the contents fade - scale content to fill via kCAGravityResize + nearest-neighbour filters - IOSurface supports Opaque|Premultiplied only; update supports_alpha_mode and AlphaMode platform docs accordingly - swap deps: drop CGDataProvider/CGImage, add objc2-io-surface + CF Number/String/Dictionary features Replaces the branch's earlier triple/unbounded-buffer commits; upstream moved to single-buffering (rust-windowing#343) while rust-windowing#329 kept multi-buffering. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently create a new
Veceach timenext_bufferis called on macOS/iOS, which is inefficient, we should instead re-use the previous buffer.Tested on:
Should help with #83.
Extracted from #329 (since that one may be more difficult to land).