macOS: Feature-gate CGSSetWindowBackgroundBlurRadius#4541
Conversation
Behind the Cargo feature `private-apple-apis`.
madsmtm
added
B - bug
| } | ||
|
|
||
| // TODO: Implement blur using public methods somehow? | ||
| let _ = blur; |
There was a problem hiding this comment.
This requires subviews and some other tech, I think.
There was a problem hiding this comment.
Either that, or maybe somehow add the blur to the CALayer with a CIFilter? Dunno, haven't investigated it
There was a problem hiding this comment.
I think the filter itself is a view, but it's what I found last time.
| #[cfg(feature = "private-apple-apis")] | ||
| { | ||
| #[link(name = "CoreGraphics", kind = "framework")] | ||
| unsafe extern "C" { |
There was a problem hiding this comment.
Not sure why we need to move it here? The old place was just fine.
There was a problem hiding this comment.
I kinda like that the cfg is scoped to a single spot. But I can move it back if you want?
There was a problem hiding this comment.
I like having application wide symbols exported in place that represents that visibily, other than just inside some random function.
Since those ones can be used by any other function.
|
Is there any update on this PR? Would be nice to not have to write a custom patch every time I need to submit a new app for MAS to review :) |
|
I just saw this thread after I submitted my PR. I'm somewhat eager to hear what y'all think. I think it might make everyone happy. If not, I thought of one other way to do it besides this way. So, let me know. |
5 participants
Feature-gate
CGSSetWindowBackgroundBlurRadiusbehind the Cargo featureprivate-apple-apis.Fixes #4205.
set_blur(true)works both with and without the feature enabled.changelogmodule if knowledge of this change could be valuable to users