Skip to content

Commit 9833ef5

Browse files
committed
Merge bitcoin#34702: doc: Fix fee field in getblock RPC result
f580cc7 doc: Fix `fee` field in `getblock` RPC result (nervana21) Pull request description: The `fee` field in the `getblock` RPC result (verbosity 2 and 3) may be omitted when block undo data is not available. Marking it optional in the `RPCResult` aligns the documented schema with the runtime behavior. ACKs for top commit: mercie-ux: ACK bitcoin@f580cc7 satsfy: ACK bitcoin@f580cc7 instagibbs: ACK f580cc7 w0xlt: ACK f580cc7 luke-jr: ACK f580cc7 Tree-SHA512: e3b44a48e17e21b906967aef124688a34aea2c6af3b6df3c47693fd3002d33e824f764c0060a7ab07751b98567c29eb16f3b3c07bf2999db080ff7adfd087dfd
2 parents f2f0a0c + f580cc7 commit 9833ef5

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

src/rpc/blockchain.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -816,7 +816,7 @@ static RPCHelpMan getblock()
816816
{RPCResult::Type::OBJ, "", "",
817817
{
818818
{RPCResult::Type::ELISION, "", "The transactions in the format of the getrawtransaction RPC. Different from verbosity = 1 \"tx\" result"},
819-
{RPCResult::Type::NUM, "fee", "The transaction fee in " + CURRENCY_UNIT + ", omitted if block undo data is not available"},
819+
{RPCResult::Type::NUM, "fee", /*optional=*/true, "The transaction fee in " + CURRENCY_UNIT + ", omitted if block undo data is not available"},
820820
}},
821821
}},
822822
}},

0 commit comments

Comments
 (0)