scripted-diff: Prefer static constexpr for literal-type constants

-BEGIN VERIFY SCRIPT-
git grep -l 'static const ' -- 'src/' ':(exclude)src/secp256k1/' \
  | xargs sed -i -E '/\b(MIN_TRANSACTION_OUTPUT_WEIGHT|MAX_OUTPUTS_PER_BLOCK|MAX_FILTER|g_rng_temp_path_init)\b/!s/\bstatic const (bool|int|unsigned|size_t|CAmount|u?int(8|16|32|64)_t|std::chrono::[a-z_]+) /static constexpr \1 /g'
-END VERIFY SCRIPT-

Author: rustaceanrob

src/base58.cpp

@@ -18,7 +18,7 @@ using util::ContainsNoNUL;
 
 /** All alphanumeric characters except for "0", "I", "O", and "l" */
 static const char* pszBase58 = "123456789ABCDEFGHJKLMNPQRSTUVWXYZabcdefghijkmnopqrstuvwxyz";
-static const int8_t mapBase58[256] = {
+static constexpr int8_t mapBase58[256] = {
     -1,-1,-1,-1,-1,-1,-1,-1, -1,-1,-1,-1,-1,-1,-1,-1,
     -1,-1,-1,-1,-1,-1,-1,-1, -1,-1,-1,-1,-1,-1,-1,-1,
     -1,-1,-1,-1,-1,-1,-1,-1, -1,-1,-1,-1,-1,-1,-1,-1,

src/bench/chacha20.cpp

@@ -15,9 +15,9 @@
 #include <vector>
 
 /* Number of bytes to process per iteration */
-static const uint64_t BUFFER_SIZE_TINY  = 64;
-static const uint64_t BUFFER_SIZE_SMALL = 256;
-static const uint64_t BUFFER_SIZE_LARGE{1_MiB};
+static constexpr uint64_t BUFFER_SIZE_TINY  = 64;
+static constexpr uint64_t BUFFER_SIZE_SMALL = 256;
+static constexpr uint64_t BUFFER_SIZE_LARGE{1_MiB};
 
 static void CHACHA20(benchmark::Bench& bench, size_t buffersize)
 {

src/bench/checkqueue.cpp

@@ -16,9 +16,9 @@
 #include <utility>
 #include <vector>
 
-static const size_t BATCHES = 101;
-static const size_t BATCH_SIZE = 30;
-static const unsigned int QUEUE_BATCH_SIZE = 128;
+static constexpr size_t BATCHES = 101;
+static constexpr size_t BATCH_SIZE = 30;
+static constexpr unsigned int QUEUE_BATCH_SIZE = 128;
 
 // This Benchmark tests the CheckQueue with a slightly realistic workload,
 // where checks all contain a prevector that is indirect 50% of the time

src/bench/crypto_hash.cpp

@@ -20,7 +20,7 @@
 #include <vector>
 
 /* Number of bytes to hash per iteration */
-static const uint64_t BUFFER_SIZE = 1000*1000;
+static constexpr uint64_t BUFFER_SIZE = 1000*1000;
 
 static void BenchRIPEMD160(benchmark::Bench& bench)
 {

src/bitcoin-cli.cpp

@@ -62,10 +62,10 @@ const TranslateFn G_TRANSLATION_FUN{nullptr};
 
 static const char DEFAULT_RPCCONNECT[] = "127.0.0.1";
 static constexpr const char* DEFAULT_RPC_REQ_ID{"1"};
-static const int DEFAULT_HTTP_CLIENT_TIMEOUT=900;
+static constexpr int DEFAULT_HTTP_CLIENT_TIMEOUT=900;
 static constexpr int DEFAULT_WAIT_CLIENT_TIMEOUT = 0;
-static const bool DEFAULT_NAMED=false;
-static const int CONTINUE_EXECUTION=-1;
+static constexpr bool DEFAULT_NAMED=false;
+static constexpr int CONTINUE_EXECUTION=-1;
 static constexpr uint8_t NETINFO_MAX_LEVEL{4};
 static constexpr int8_t UNKNOWN_NETWORK{-1};
 // See GetNetworkName() in netbase.cpp

src/bitcoin-tx.cpp

@@ -40,7 +40,7 @@ using util::TrimStringView;
 
 static bool fCreateBlank;
 static std::map<std::string,UniValue> registers;
-static const int CONTINUE_EXECUTION=-1;
+static constexpr int CONTINUE_EXECUTION=-1;
 
 const TranslateFn G_TRANSLATION_FUN{nullptr};
 
@@ -271,8 +271,8 @@ static void MutateTxAddInput(CMutableTransaction& tx, const std::string& strInpu
         throw std::runtime_error("invalid TX input txid");
     }
 
-    static const unsigned int minTxOutSz = 9;
-    static const unsigned int maxVout = MAX_BLOCK_WEIGHT / (WITNESS_SCALE_FACTOR * minTxOutSz);
+    static constexpr unsigned int minTxOutSz = 9;
+    static constexpr unsigned int maxVout = MAX_BLOCK_WEIGHT / (WITNESS_SCALE_FACTOR * minTxOutSz);
 
     // extract and validate vout
     const std::string& strVout = vStrInputParts[1];
@@ -524,7 +524,7 @@ static void MutateTxDelOutput(CMutableTransaction& tx, const std::string& strOut
     tx.vout.erase(tx.vout.begin() + *idx);
 }
 
-static const unsigned int N_SIGHASH_OPTS = 7;
+static constexpr unsigned int N_SIGHASH_OPTS = 7;
 static const struct {
     const char *flagStr;
     int flags;

src/bitcoin-util.cpp

@@ -25,7 +25,7 @@
 #include <memory>
 #include <thread>
 
-static const int CONTINUE_EXECUTION=-1;
+static constexpr int CONTINUE_EXECUTION=-1;
 
 const TranslateFn G_TRANSLATION_FUN{nullptr};
 

src/chainparamsseeds.h

@@ -10,7 +10,7 @@
  *
  * Each line contains a BIP155 serialized (networkID, addr, port) tuple.
  */
-static const uint8_t chainparams_seed_main[] = {
+static constexpr uint8_t chainparams_seed_main[] = {
     0x06,0x10,0xfc,0x11,0xf7,0x69,0x16,0xe6,0x36,0x11,0x58,0xae,0x1d,0x4a,0xfc,0xf7,0x57,0xa4,0x20,0x8d,
     0x06,0x10,0xfc,0x17,0x43,0x69,0x54,0x14,0x4b,0x1f,0x56,0x89,0xd3,0xed,0x40,0x39,0x33,0x5c,0x20,0x8d,
     0x06,0x10,0xfc,0x1f,0x22,0xc3,0x95,0xdc,0xa3,0xaf,0x4a,0x93,0x82,0x51,0xbe,0xb9,0x18,0x58,0x20,0x8d,
@@ -2072,7 +2072,7 @@ static const uint8_t chainparams_seed_main[] = {
     0x04,0x20,0xce,0x07,0x95,0xf3,0xa5,0xc1,0x90,0xc4,0x50,0xd5,0x22,0x86,0xa7,0x26,0x37,0x08,0xa2,0x31,0x1e,0x0d,0x77,0x48,0x0d,0x46,0xe0,0xfb,0x3d,0x71,0x60,0xe7,0x1d,0xce,0x20,0x8d,
 };
 
-static const uint8_t chainparams_seed_signet[] = {
+static constexpr uint8_t chainparams_seed_signet[] = {
     0x06,0x10,0xfc,0x1f,0x22,0xc3,0x95,0xdc,0xa3,0xaf,0x4a,0x93,0x82,0x51,0xbe,0xb9,0x18,0x58,0x95,0xbd,
     0x05,0x20,0xd7,0x4d,0xd9,0xc4,0x7c,0x80,0x24,0x1d,0x48,0x2f,0x52,0xba,0x2a,0xaf,0x5d,0xf2,0xfc,0x04,0x58,0x56,0x4a,0x61,0x0f,0xde,0x4e,0xd8,0x13,0x55,0x98,0x55,0x53,0xc1,0x00,0x00,
     0x05,0x20,0xd8,0xaf,0x32,0x40,0x0d,0x25,0x72,0x91,0xf5,0x14,0x2a,0xa7,0x7b,0x9f,0x6b,0xe8,0x02,0x9f,0x16,0x5e,0xa0,0xe0,0x6d,0x85,0xcc,0x79,0xf2,0xe2,0xc1,0x2b,0xe0,0x20,0x00,0x00,
@@ -2245,7 +2245,7 @@ static const uint8_t chainparams_seed_signet[] = {
     0x04,0x20,0xc9,0x95,0x5a,0xf7,0x9a,0x27,0x09,0x6a,0xa2,0x24,0x65,0xb7,0x07,0xf0,0x28,0xee,0x8b,0xa9,0x5e,0x7c,0x37,0x19,0x14,0xc4,0x36,0x73,0x42,0xd2,0x87,0xae,0xa2,0x47,0x95,0xbd,
 };
 
-static const uint8_t chainparams_seed_test[] = {
+static constexpr uint8_t chainparams_seed_test[] = {
     0x06,0x10,0xfc,0x1f,0x22,0xc3,0x95,0xdc,0xa3,0xaf,0x4a,0x93,0x82,0x51,0xbe,0xb9,0x18,0x58,0x47,0x9d,
     0x05,0x20,0x39,0x06,0xc0,0x95,0x12,0xe1,0xf8,0x86,0xc2,0x36,0x76,0xa9,0x96,0x2a,0x9d,0xbd,0x3d,0x70,0x43,0xfc,0x99,0xbf,0x27,0x15,0xa4,0x9c,0x10,0xa1,0xd5,0xa3,0x9d,0x52,0x00,0x00,
     0x05,0x20,0x40,0x81,0xae,0x55,0xb2,0x9d,0xd0,0xff,0x99,0x51,0xd8,0xbc,0x35,0xb2,0x06,0xb7,0x1c,0xf6,0x16,0x35,0xae,0xc6,0xf7,0xa4,0x72,0xf8,0x37,0x41,0x8e,0x91,0x7b,0x2e,0x00,0x00,
@@ -2429,7 +2429,7 @@ static const uint8_t chainparams_seed_test[] = {
     0x04,0x20,0xcc,0x99,0x76,0x52,0x43,0xcc,0x45,0x0a,0x49,0x5d,0x3f,0xa5,0x82,0xc3,0xc0,0xdb,0xcf,0xe5,0xda,0xfb,0xb3,0xd0,0xb9,0xd1,0xbc,0x1b,0x15,0x19,0xed,0xe0,0xd1,0x5f,0x47,0x9d,
 };
 
-static const uint8_t chainparams_seed_testnet4[] = {
+static constexpr uint8_t chainparams_seed_testnet4[] = {
     0x06,0x10,0xfc,0x1f,0x22,0xc3,0x95,0xdc,0xa3,0xaf,0x4a,0x93,0x82,0x51,0xbe,0xb9,0x18,0x58,0xbc,0xcd,
     0x05,0x20,0xd3,0xbc,0x25,0x95,0x63,0x7f,0x34,0x02,0x18,0x69,0x91,0x9a,0x79,0x57,0x10,0xc0,0xe0,0xf5,0xcd,0x84,0x56,0x95,0xec,0x43,0xa4,0x9d,0xba,0x1b,0xb3,0xea,0x34,0x60,0x00,0x00,
     0x05,0x20,0xd8,0xee,0x64,0x35,0x6c,0x53,0xe7,0x40,0xb8,0xc3,0x15,0x60,0x5b,0x9c,0x66,0x3d,0xbb,0xd9,0x7c,0x99,0xcc,0x3a,0x3a,0xf6,0xcb,0xd5,0xd4,0x51,0x98,0x04,0x68,0xad,0x00,0x00,

src/clientversion.h

@@ -23,7 +23,7 @@
 #include <string>
 #include <vector>
 
-static const int CLIENT_VERSION =
+static constexpr int CLIENT_VERSION =
                              10000 * CLIENT_VERSION_MAJOR
                          +     100 * CLIENT_VERSION_MINOR
                          +       1 * CLIENT_VERSION_BUILD;

src/compressor.h

@@ -59,7 +59,7 @@ struct ScriptCompression
      * transactions, in which case this value becomes dependent on version
      * and nHeight of the enclosing transaction.
      */
-    static const unsigned int nSpecialScripts = 6;
+    static constexpr unsigned int nSpecialScripts = 6;
 
     template<typename Stream>
     void Ser(Stream &s, const CScript& script) {