Skip to content

feat(oidc): add roles claim field to provider settings#98

Merged
overtrue merged 1 commit intorustfs:mainfrom
GatewayJ:feat/oidc-roles-claim-ui
Apr 12, 2026
Merged

feat(oidc): add roles claim field to provider settings#98
overtrue merged 1 commit intorustfs:mainfrom
GatewayJ:feat/oidc-roles-claim-ui

Conversation

@GatewayJ
Copy link
Copy Markdown
Member

Pull Request

Description

Adds Roles claim (roles_claim) to the OIDC provider form and API payload so the Console stays aligned with RustFS admin API. Loading and saving now includes roles_claim, preventing saves from clearing a previously configured value on the server.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test improvements
  • Security fix

Testing

  • Unit tests added/updated
  • Manual testing completed
pnpm exec eslint types/oidc.ts "app/(dashboard)/oidc/page.tsx" components/oidc/form.tsx

Checklist

  • Code follows the project's style guidelines
  • Self-review completed
  • TypeScript types are properly defined
  • All commit messages are in English (Conventional Commits)
  • All existing tests pass (full tsc may report existing Next.js .next type issues in this environment)
  • No new dependencies added, or they are justified

Related Issues

Closes #

Screenshots (if applicable)

N/A

Additional Notes

Pairs with RustFS server support for roles_claim on OIDC provider config. i18n: full strings for en-US and zh-CN; other locales include English placeholders for the new keys.

- Extend OIDC types and save payload with roles_claim
- Map roles_claim in form load/save to avoid clearing server config
- Add Roles Claim field and i18n strings

Made-with: Cursor
@overtrue overtrue merged commit 8ab0668 into rustfs:main Apr 12, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants