Remove all allow flags and clean up clippy warnings

- Removed all #[allow()] attributes throughout the codebase
- Fixed naming convention warning (gRPC -> GRpc)
- Removed unused enum variants and dead code in Rust AST mapper
- Cleaned up lifetime analysis implementation to remove unused fields and methods
- Fixed compilation errors related to removed variance fields

All tests pass, clippy passes without errors, and only acceptable warnings remain
(dead code, unused fields for future features, complex function signatures).

This improves code quality by ensuring all warnings are visible and not hidden
behind allow flags, making the codebase more maintainable and following
Rust best practices.

Author: milliondreams

crates/codeprism-analysis/src/duplicates.rs

@@ -65,7 +65,6 @@ pub struct DuplicateSavings {
 /// Advanced duplicate analyzer with AST and semantic analysis
 pub struct DuplicateAnalyzer {
     /// Cache for parsed AST structures
-    #[allow(dead_code)]
     ast_cache: HashMap<String, AstNode>,
     /// Language-specific analyzers for different programming languages
     language_analyzers: HashMap<String, LanguageAnalyzer>,
@@ -76,7 +75,6 @@ pub struct DuplicateAnalyzer {
 #[derive(Debug, Clone)]
 struct LanguageAnalyzer {
     keywords: Vec<String>,
-    #[allow(dead_code)]
     operators: Vec<String>,
     control_structures: Vec<String>,
     comment_patterns: Vec<String>,

crates/codeprism-core/src/content/parsers.rs

@@ -133,13 +133,10 @@ pub struct MarkdownParser {
     /// Regex for code blocks
     code_block_regex: Regex,
     /// Regex for inline code
-    #[allow(dead_code)]
     inline_code_regex: Regex,
     /// Regex for links
-    #[allow(dead_code)]
     link_regex: Regex,
     /// Regex for lists
-    #[allow(dead_code)]
     list_regex: Regex,
 }
 
@@ -432,7 +429,6 @@ impl ConfigParser {
     }
 
     /// Extract values from JSON recursively
-    #[allow(clippy::only_used_in_recursion)]
     fn extract_json_values(
         &self,
         value: &Value,

crates/codeprism-core/src/linkers/symbol_resolver.rs

@@ -18,7 +18,6 @@ pub struct SymbolResolver {
     /// Index of symbols by qualified name (module.symbol)
     qualified_symbols: HashMap<String, NodeId>,
     /// Import resolution cache
-    #[allow(dead_code)]
     import_cache: HashMap<String, String>,
 }
 

crates/codeprism-core/src/watcher/mod.rs

@@ -104,7 +104,6 @@ impl Debouncer {
 /// File system watcher
 pub struct FileWatcher {
     watcher: RecommendedWatcher,
-    #[allow(dead_code)] // Used indirectly through Arc
     debouncer: Arc<Debouncer>,
     change_rx: mpsc::UnboundedReceiver<ChangeEvent>,
     watched_paths: Arc<Mutex<Vec<PathBuf>>>,

crates/codeprism-dev-tools/src/ast_visualizer.rs

@@ -494,7 +494,6 @@ impl AstVisualizer {
     }
 
     /// Recursively collect AST statistics
-    #[allow(clippy::only_used_in_recursion)]
     fn collect_statistics(&self, node: &Node, stats: &mut AstStatistics, depth: usize) {
         stats.total_nodes += 1;
         stats.max_depth = stats.max_depth.max(depth);
@@ -615,7 +614,6 @@ mod tests {
     use super::*;
     use tree_sitter::Parser;
 
-    #[allow(dead_code)]
     fn create_test_parser() -> Parser {
         // For testing, we'll use a simple language grammar
         // In real usage, this would use the appropriate language

crates/codeprism-dev-tools/src/diff_comparison.rs

@@ -392,7 +392,6 @@ impl AstDiff {
     }
 
     /// Calculate tree depth
-    #[allow(clippy::only_used_in_recursion)]
     fn calculate_tree_depth(&self, node: &tree_sitter::Node) -> usize {
         let mut max_depth = 0;
         for i in 0..node.child_count() {

crates/codeprism-lang-js/src/analysis.rs

@@ -580,7 +580,6 @@ pub struct WebSocketSecurityAssessment {
 
 /// WebSocket authentication methods
 #[derive(Debug, Clone)]
-#[allow(clippy::upper_case_acronyms)]
 pub enum WebSocketAuthMethod {
     Jwt,
     SessionBased,
@@ -612,7 +611,6 @@ pub enum ScalingStrategy {
 }
 
 /// Advanced Node.js pattern analysis (Phase 1.3)
-#[allow(dead_code)]
 #[derive(Debug, Clone)]
 pub struct AdvancedNodePatternInfo {
     pub pattern_type: AdvancedNodePatternType,
@@ -624,7 +622,6 @@ pub struct AdvancedNodePatternInfo {
 }
 
 /// Advanced Node.js pattern types
-#[allow(dead_code)]
 #[derive(Debug, Clone)]
 pub enum AdvancedNodePatternType {
     SecurityMiddleware,
@@ -637,7 +634,6 @@ pub enum AdvancedNodePatternType {
 }
 
 /// Middleware information
-#[allow(dead_code)]
 #[derive(Debug, Clone)]
 pub struct MiddlewareInfo {
     pub name: String,
@@ -649,7 +645,6 @@ pub struct MiddlewareInfo {
 }
 
 /// Middleware types
-#[allow(dead_code)]
 #[derive(Debug, Clone)]
 pub enum MiddlewareType {
     Authentication,
@@ -665,7 +660,6 @@ pub enum MiddlewareType {
 }
 
 /// Error handling pattern information
-#[allow(dead_code)]
 #[derive(Debug, Clone)]
 pub struct ErrorHandlingPattern {
     pub pattern_type: ErrorHandlingType,
@@ -676,7 +670,6 @@ pub struct ErrorHandlingPattern {
 }
 
 /// Error handling types
-#[allow(dead_code)]
 #[derive(Debug, Clone)]
 pub enum ErrorHandlingType {
     TryCatch,
@@ -689,7 +682,6 @@ pub enum ErrorHandlingType {
 }
 
 /// Error classification
-#[allow(dead_code)]
 #[derive(Debug, Clone)]
 pub struct ErrorClassification {
     pub error_type: ErrorType,
@@ -699,8 +691,6 @@ pub struct ErrorClassification {
 }
 
 /// Error types
-#[allow(dead_code)]
-#[allow(clippy::enum_variant_names)]
 #[derive(Debug, Clone)]
 pub enum ErrorType {
     ValidationError,
@@ -714,7 +704,6 @@ pub enum ErrorType {
 }
 
 /// Error severity levels
-#[allow(dead_code)]
 #[derive(Debug, Clone)]
 pub enum ErrorSeverity {
     Critical,
@@ -725,7 +714,6 @@ pub enum ErrorSeverity {
 }
 
 /// User impact levels
-#[allow(dead_code)]
 #[derive(Debug, Clone)]
 pub enum UserImpact {
     ServiceUnavailable,
@@ -735,7 +723,6 @@ pub enum UserImpact {
 }
 
 /// Performance indicator for advanced patterns
-#[allow(dead_code)]
 #[derive(Debug, Clone)]
 pub struct PerformanceIndicator {
     pub indicator_type: PerformanceType,
@@ -746,8 +733,6 @@ pub struct PerformanceIndicator {
 }
 
 /// Performance types
-#[allow(dead_code)]
-#[allow(clippy::upper_case_acronyms)]
 #[derive(Debug, Clone)]
 pub enum PerformanceType {
     Memory,
@@ -761,7 +746,6 @@ pub enum PerformanceType {
 }
 
 /// Performance metrics
-#[allow(dead_code)]
 #[derive(Debug, Clone)]
 pub struct PerformanceMetrics {
     pub response_time: Option<f64>,
@@ -772,7 +756,6 @@ pub struct PerformanceMetrics {
 }
 
 /// Microservice pattern information
-#[allow(dead_code)]
 #[derive(Debug, Clone)]
 pub struct MicroservicePattern {
     pub pattern_name: String,
@@ -783,21 +766,17 @@ pub struct MicroservicePattern {
 }
 
 /// Service communication patterns
-#[allow(dead_code)]
-#[allow(clippy::upper_case_acronyms)]
-#[allow(non_camel_case_types)]
 #[derive(Debug, Clone)]
 pub enum ServiceCommunication {
     Http,
     GraphQL,
-    gRPC,
+    GRpc,
     MessageQueue,
     EventStream,
     WebSocket,
 }
 
 /// Data consistency patterns
-#[allow(dead_code)]
 #[derive(Debug, Clone)]
 pub enum DataConsistency {
     Strong,
@@ -808,7 +787,6 @@ pub enum DataConsistency {
 }
 
 /// Fault tolerance patterns
-#[allow(dead_code)]
 #[derive(Debug, Clone)]
 pub enum FaultTolerance {
     CircuitBreaker,
@@ -820,7 +798,6 @@ pub enum FaultTolerance {
 }
 
 /// Monitoring levels
-#[allow(dead_code)]
 #[derive(Debug, Clone)]
 pub enum MonitoringLevel {
     Comprehensive,
@@ -830,7 +807,6 @@ pub enum MonitoringLevel {
 }
 
 /// Database pattern information
-#[allow(dead_code)]
 #[derive(Debug, Clone)]
 pub struct DatabasePattern {
     pub database_type: DatabaseType,
@@ -841,7 +817,6 @@ pub struct DatabasePattern {
 }
 
 /// Database types
-#[allow(dead_code)]
 #[derive(Debug, Clone)]
 pub enum DatabaseType {
     PostgreSQL,
@@ -855,8 +830,6 @@ pub enum DatabaseType {
 }
 
 /// Database access patterns
-#[allow(dead_code)]
-#[allow(clippy::upper_case_acronyms)]
 #[derive(Debug, Clone)]
 pub enum DatabaseAccessPattern {
     DirectAccess,
@@ -868,7 +841,6 @@ pub enum DatabaseAccessPattern {
 }
 
 /// Optimization levels
-#[allow(dead_code)]
 #[derive(Debug, Clone)]
 pub enum OptimizationLevel {
     High,
@@ -878,7 +850,6 @@ pub enum OptimizationLevel {
 }
 
 /// Connection management patterns
-#[allow(dead_code)]
 #[derive(Debug, Clone)]
 pub enum ConnectionManagement {
     Pool,
@@ -889,8 +860,6 @@ pub enum ConnectionManagement {
 }
 
 /// Transaction handling patterns
-#[allow(dead_code)]
-#[allow(clippy::upper_case_acronyms)]
 #[derive(Debug, Clone)]
 pub enum TransactionHandling {
     Acid,
@@ -907,18 +876,12 @@ pub struct JavaScriptAnalyzer {
     react_patterns: HashMap<String, Regex>,
     nodejs_patterns: HashMap<String, Regex>,
     typescript_patterns: HashMap<String, Regex>,
-    #[allow(dead_code)]
     vue_patterns: HashMap<String, Regex>,
-    #[allow(dead_code)]
     angular_patterns: HashMap<String, Regex>,
     // Phase 1.3 additions
-    #[allow(dead_code)]
     security_patterns: HashMap<String, Regex>,
-    #[allow(dead_code)]
     performance_patterns: HashMap<String, Regex>,
-    #[allow(dead_code)]
     websocket_patterns: HashMap<String, Regex>,
-    #[allow(dead_code)]
     advanced_typescript_patterns: HashMap<String, Regex>,
 }
 
@@ -1659,7 +1622,6 @@ impl JavaScriptAnalyzer {
         }
     }
 
-    #[allow(dead_code)]
     fn extract_route_parameters(&self, path: &str) -> Vec<String> {
         let param_pattern = Regex::new(r":(\w+)").unwrap();
         param_pattern

crates/codeprism-lang-python/src/analysis.rs

@@ -400,7 +400,6 @@ pub struct TypeHintInfo {
 
 /// Type hint types
 #[derive(Debug, Clone)]
-#[allow(clippy::enum_variant_names)]
 pub enum TypeHintType {
     SimpleType(String),             // int, str, bool
     UnionType(Vec<String>),         // Union[str, int] or str | int
@@ -1116,7 +1115,6 @@ pub enum LicenseCompatibility {
 struct DependencyPattern {
     name: String,
     pattern: Regex,
-    #[allow(dead_code)]
     file_type: RequirementsFileType,
     extraction_method: String,
 }
@@ -1541,7 +1539,6 @@ pub enum FeatureComplexity {
 struct ModernFeaturePattern {
     name: String,
     pattern: Regex,
-    #[allow(dead_code)]
     feature_type: String,
     python_version: String,
     complexity: FeatureComplexity,
@@ -1571,15 +1568,13 @@ struct DecoratorPattern {
 
 #[derive(Debug, Clone)]
 struct MetaclassPattern {
-    #[allow(dead_code)]
     name: String,
     pattern: Regex,
     impact: String,
 }
 
 #[derive(Debug, Clone)]
 struct SecurityPattern {
-    #[allow(dead_code)]
     name: String,
     pattern: Regex,
     vulnerability_type: VulnerabilityType,
@@ -1589,7 +1584,6 @@ struct SecurityPattern {
 
 #[derive(Debug, Clone)]
 struct PerformancePattern {
-    #[allow(dead_code)]
     name: String,
     pattern: Regex,
     optimization_type: OptimizationType,
@@ -1599,7 +1593,6 @@ struct PerformancePattern {
 
 #[derive(Debug, Clone)]
 struct FrameworkPattern {
-    #[allow(dead_code)]
     name: String,
     pattern: Regex,
     framework: String,
@@ -4016,7 +4009,6 @@ impl PythonAnalyzer {
     }
 
     /// Calculate overall modernity score
-    #[allow(clippy::too_many_arguments)]
     fn calculate_modernity_score(
         &self,
         dataclass_features: &[DataclassInfo],
@@ -4042,7 +4034,6 @@ impl PythonAnalyzer {
     }
 
     /// Generate modern feature recommendations
-    #[allow(clippy::too_many_arguments)]
     fn get_modern_feature_recommendations(
         &self,
         dataclass_features: &[DataclassInfo],