feat: added tls handshake timeout#178
Open
lucastemb wants to merge 1 commit into
Open
Conversation
Member
|
Thanks! This looked broadly good, but I had some review feedback (see the PR description in #182). Ultimately instead of suggesting edits here I decided to open a separate PR with my feedback folded into your original commit so I could see what this looks like if we draw the rest of the owl and add timeout support to the server-side pieces as follow-up commits. I think it makes sense to look at the whole thing at once, but if folks disagree we can also take (some of || all of) the fixup commits I made in 182, apply them here, land this PR, and then look at the server-side separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional client-side TLS handshake timeout to
TlsConnector.The timeout is configured with
with_handshake_timeout(Some(Duration))and applies only while the TLS handshake is pending. If the handshake does not complete before the deadline, the connect future returns anio::ErrorKind::TimedOut.FallibleConnectpreserves its existing behavior of returning the underlying IO on failure.A regression test covers an idle peer timing out during handshake.
Motivated by: