Upgrade to clubcard-crlite 0.5#174
Conversation
|
Going to see if we can get |
|
It's a little weird the benchmark is failing here... I'm also seeing that on one of my macOS machines, the performance effect from on Do we still think this is the right trade-off? When the benchmark passes (seems intermittent locally -- also bad), "use internal SHA-256 implementation for hashing" seems to worsen performance on the same benchmark by another 15%. |
|
Okay, part of the problem was that I got the hashing operation for the key wrong. With that fixed, my results from benchmarking 1c9dd7a (last commit before #181) against the tip of this branch are:
I guess that's fine; still a little weird/worrying that these changes are not visible on Codspeed. |
|
Going to hold off on releasing until we have merged at least. Let me know if you know of other things that should block this. |
No description provided.