Skip to content

Upgrade to clubcard-crlite 0.5#174

Merged
djc merged 3 commits into
mainfrom
clubcard-crlite-0.5
Jul 8, 2026
Merged

Upgrade to clubcard-crlite 0.5#174
djc merged 3 commits into
mainfrom
clubcard-crlite-0.5

Conversation

@djc

@djc djc commented Jun 25, 2026

Copy link
Copy Markdown
Member

No description provided.

@djc djc requested a review from ctz June 25, 2026 22:34
@djc

djc commented Jun 26, 2026

Copy link
Copy Markdown
Member Author

Going to see if we can get

@djc djc force-pushed the clubcard-crlite-0.5 branch from 0739784 to c2b7a4b Compare July 6, 2026 08:45
@djc djc requested a review from ctz July 6, 2026 08:45
@djc

djc commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

It's a little weird the benchmark is failing here...

I'm also seeing that on one of my macOS machines, the performance effect from

on revocation-input-from-certs seems to be not good:

revocation-input-from-certs
                        time:   [761.48 ns 763.69 ns 766.11 ns]
                        change: [+32.633% +33.217% +33.805%] (p = 0.00 < 0.05)
                        Performance has regressed.

Do we still think this is the right trade-off?

When the benchmark passes (seems intermittent locally -- also bad), "use internal SHA-256 implementation for hashing" seems to worsen performance on the same benchmark by another 15%.

@djc djc force-pushed the clubcard-crlite-0.5 branch from c2b7a4b to 9a0b756 Compare July 6, 2026 09:13
@djc djc force-pushed the clubcard-crlite-0.5 branch from 9a0b756 to 0e4e447 Compare July 6, 2026 10:11
@codspeed-hq

codspeed-hq Bot commented Jul 6, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 4 untouched benchmarks


Comparing clubcard-crlite-0.5 (0e4e447) with main (9c812ec)

Open in CodSpeed

@djc

djc commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

Okay, part of the problem was that I got the hashing operation for the key wrong. With that fixed, my results from benchmarking 1c9dd7a (last commit before #181) against the tip of this branch are:

  • +59% on revocation-input-from-certs (570ns -> 910ns)
  • -4.7% on revocation-check (1.0ms -> 0.99ms)

I guess that's fine; still a little weird/worrying that these changes are not visible on Codspeed.

@djc djc added this pull request to the merge queue Jul 8, 2026
@djc

djc commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

Going to hold off on releasing until we have

merged at least. Let me know if you know of other things that should block this.

Merged via the queue into main with commit 8fbaf77 Jul 8, 2026
15 checks passed
@djc djc deleted the clubcard-crlite-0.5 branch July 8, 2026 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants