upki: check all filters#185
Merged
Merged
Conversation
cpu
reviewed
Jul 7, 2026
Member
Author
|
Ugh, sorry, that was a bit sloppy. Should be better now, and I've added more test coverage to handle these cases. Thanks for the careful review! |
Member
|
Are the test failures a product of needing to rebase w/ #188 or actual failures? I'm wondering if I should re-review now or wait a bit longer. |
Member
Author
Oops, thanks for calling that out. I think the test failures were unrelated, and this is ready to review. I've rebased it on current |
cpu
reviewed
Jul 9, 2026
ctz
approved these changes
Jul 10, 2026
cpu
approved these changes
Jul 10, 2026
cpu
left a comment
cpu
left a comment
Member
There was a problem hiding this comment.
Nice 👍 LGTM. I'll update the C2SP spec text to cover this shortly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #183.
(Tests generated with help from Claude.)