revocation: de-duplicate redundant check work#192
Merged
Conversation
Since a covering filter is queried with every SCT timestamp, consulting it again for a later SCT can't produce a different answer. Remember which filter files have been seen & processed and avoid re-doing that work.
djc
approved these changes
Jul 13, 2026
Member
|
Nice, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick follow-up to #185
Since a covering filter is queried with every SCT timestamp, consulting it again for a later SCT can't produce a different answer. Remember which filter files have been seen & processed and avoid re-doing that work.
I think writing a test to explicitly confirm a file isn't read more than once would require adding test-specific indirection so I've skipped that for now.