Fix ApplyLexiconToCorpusJob#646
Open
guest-tz wants to merge 3 commits into
Open
Conversation
Icemole
requested review from
Icemole,
JackTemaki,
albertz,
curufinwe and
michelwi
Icemole
approved these changes
Feb 18, 2026
Icemole
left a comment
Icemole
left a comment
Collaborator
There was a problem hiding this comment.
Nice find! With such a pattern you could technically have more edge cases, such as double space:
>>> "hello world".split(" ")
['hello', '', 'world']
I assume nobody has run into this yet, so from my side we're good to merge.
Perhaps it would also be wise to filter your empty segments from the corpus by doing some fast postprocessing.
michelwi
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing LookupError if orth is empty.
The fix
''.split()returns empty list while current version''.split(" ")returns['']and causes LookupError.