Modify some operations to be compatible for torch.onnx.export#1823
Draft
robin-p-schmitt wants to merge 2 commits into
Draft
Modify some operations to be compatible for torch.onnx.export#1823robin-p-schmitt wants to merge 2 commits into
robin-p-schmitt wants to merge 2 commits into
Conversation
Contributor
|
Just some thoughts in general. FYI, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am currently trying to export a CTC model based on the RF Conformer with torch.onnx.export. For this, some operations need to be modified:
return_complex=Falseand handle the resulting tensor accordingly.torch.reshapecalls toTorchBackend.reshape_rawand do different checks to handle the logic withouttorch.reshape. So far, I only included the cases which I encountered during my specific ONNX export. I think the checks could maybe be designed in a smarter way which is why I marked this as a draft for now.Right now, I am stuck with one of the cases in
TorchBackend.reshape_raw:elif len(raw_tensor.shape) - len(shape) == -1:. This is true, for example, when a single dimension is split into two dimensions which are given as tensors. I am not sure whether this case can be generally handled here. Any ideas?