Skip to content

add setup_job_directory shortcut#98

Open
JackTemaki wants to merge 2 commits into
masterfrom
nick_add_shortcut
Open

add setup_job_directory shortcut#98
JackTemaki wants to merge 2 commits into
masterfrom
nick_add_shortcut

Conversation

@JackTemaki
Copy link
Copy Markdown
Contributor

No description provided.

@JackTemaki JackTemaki requested a review from critias August 31, 2022 15:58
Copy link
Copy Markdown
Contributor

@critias critias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a job isn't inside the graph this will probably crash since tk.sis_graph.find("%s") returns an empty array. Given that you check each config file individually it will not work if the first config file doesn't contain the job.

Either pass all config files at once or allow only one config file as input.

Comment thread sisyphus/shortcuts.py


def setup_job_directory(args):
for conf_file in args.argv:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does passing all config files at once cause problems?

@curufinwe curufinwe requested review from curufinwe and michelwi May 17, 2023 07:20
@curufinwe
Copy link
Copy Markdown
Collaborator

I don't mind having this shortcut. @JackTemaki is this still relevant for you?

@JackTemaki
Copy link
Copy Markdown
Contributor Author

I don't mind having this shortcut. @JackTemaki is this still relevant for you?

Well, this is just a small convenience increase that you do not have to open the console for that, I would not call it relevant.

@michelwi
Copy link
Copy Markdown
Contributor

michelwi commented Mar 4, 2025

some similar functionality is available now via #239, should we close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants