fix(adapter): allow optional 'valueId' in 'ValueReferencePair' for JSON and XML

Author: paul-gerber-svg

sdk/basyx/aas/adapter/json/json_deserialization.py

@@ -425,8 +425,10 @@ def _construct_value_list(cls, dct: Dict[str, object]) -> model.ValueList:
     @classmethod
     def _construct_value_reference_pair(cls, dct: Dict[str, object],
                                         object_class=model.ValueReferencePair) -> model.ValueReferencePair:
+        value_id_dict = dct.get('valueId')
+        value_id = cls._construct_reference(value_id_dict) if value_id_dict is not None else None
         return object_class(value=_get_ts(dct, 'value', str),
-                            value_id=cls._construct_reference(_get_ts(dct, 'valueId', dict)))
+                            value_id=value_id)
 
     # #############################################################################
     # Direct Constructor Methods (for classes with `modelType`) starting from here

sdk/basyx/aas/adapter/xml/xml_deserialization.py

@@ -1063,9 +1063,10 @@ def construct_submodel(cls, element: etree._Element, object_class=model.Submodel
     @classmethod
     def construct_value_reference_pair(cls, element: etree._Element, object_class=model.ValueReferencePair,
                                        **_kwargs: Any) -> model.ValueReferencePair:
+        value_id_element = element.find(NS_AAS + "valueId")
+        value_id = cls.construct_reference(value_id_element, **_kwargs) if value_id_element is not None else None 
         return object_class(_child_text_mandatory(element, NS_AAS + "value"),
-                            _child_construct_mandatory(element, NS_AAS + "valueId", cls.construct_reference))
-
+                            value_id)
     @classmethod
     def construct_value_list(cls, element: etree._Element, **_kwargs: Any) -> model.ValueList:
         """