fix: removed instance where i was re-implementing chucks_exact

Author: hschimke

src/oned/itf_writer.rs

@@ -47,28 +47,22 @@ impl OneDimensionalCodeWriter for ITFWriter {
 
         let mut result = vec![false; 9 + 9 * length];
         let mut pos = Self::appendPattern(&mut result, 0, &START_PATTERN, true) as usize;
-        let mut i = 0;
-        while i < length {
-            let one = contents
-                .chars()
-                .nth(i)
-                .ok_or(Exceptions::INDEX_OUT_OF_BOUNDS)?
+
+        let cached_contents: Vec<char> = contents.chars().collect();
+        for chunk in cached_contents.chunks_exact(2) {
+            let one = chunk[0]
                 .to_digit(10)
                 .ok_or(Exceptions::PARSE)? as usize;
-            let two = contents
-                .chars()
-                .nth(i + 1)
-                .ok_or(Exceptions::INDEX_OUT_OF_BOUNDS)?
+            let two = chunk[1]
                 .to_digit(10)
                 .ok_or(Exceptions::PARSE)? as usize;
+
             let mut encoding = [0; 10];
             for j in 0..5 {
                 encoding[2 * j] = PATTERNS[one][j];
                 encoding[2 * j + 1] = PATTERNS[two][j];
             }
             pos += Self::appendPattern(&mut result, pos, &encoding, true) as usize;
-
-            i += 2;
         }
         Self::appendPattern(&mut result, pos, &END_PATTERN, true);
 

src/oned/telepen_common.rs

@@ -35,25 +35,23 @@ pub fn numeric_to_ascii(contents: &str) -> Result<String> {
     }
 
     let mut ascii = Vec::with_capacity(contents.chars().count() / 2);
-    let mut i = 0;
 
-    let cached_contents = contents.chars().map(|c| c as u8).collect::<Vec<_>>();
+    let cached_contents: Vec<u8> = contents.chars().map(|c| c as u8).collect();
 
-    while i < cached_contents.len() {
-        let first = *cached_contents.get(i).unwrap();
-        let second = *cached_contents.get(i + 1).unwrap();
+    for (i, chunk) in cached_contents.chunks_exact(2).enumerate() {
+        let first = chunk[0];
+        let second = chunk[1];
 
         if second == 88 && (48..=57).contains(&first) {
             ascii.push((17 + first - 48) as char);
         } else if (48..=57).contains(&second) && (48..=57).contains(&first) {
             ascii.push((27 + (first - 48) * 10 + (second - 48)) as char);
         } else {
             return Err(Exceptions::illegal_argument_with(format!(
-                "Input contains an invalid character around position {i}."
+                "Input contains an invalid character around position {}.",
+                i * 2
             )));
         }
-
-        i += 2;
     }
 
     Ok(ascii.iter().collect())