fix: eight separate calls to strcpy(ifr in ifenslave.c#369
Open
orbisai0security wants to merge 1 commit into
Open
fix: eight separate calls to strcpy(ifr in ifenslave.c#369orbisai0security wants to merge 1 commit into
orbisai0security wants to merge 1 commit into
Conversation
Eight separate calls to strcpy(ifr
Owner
|
I appreciate your enthusiasm and will to help. But this is an old thirty party file barely anyone ever used. All pkg security things should mostly be done upstream. For this specific, exotic and rarely used thing there is unfortunately not realy an upstream anymore. I noticed thru repology version work months ago Debian has something newer: https://repology.org/project/ifenslave/versions the best is to start with updating to this first. |
Author
|
Okay, I will start with exploring the newer ifenslave version and close this PR out. |
Owner
|
Can you please stop this random issue an pr spam? Opening and closing at random. The pr or issue should have course stay open until resolved! Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
package/network/ifenslave/ifenslave.c.Vulnerability
V-001package/network/ifenslave/ifenslave.c:525Description: Eight separate calls to strcpy(ifr.ifr_name, ifname) copy a user-supplied network interface name into the fixed-size ifr_name field of struct ifreq (IFNAMSIZ = 16 bytes) without any length validation. An interface name longer than 15 characters will overflow the buffer and corrupt adjacent stack memory, potentially overwriting return addresses or function pointers. This vulnerability is confirmed with high confidence based on direct code evidence.
Changes
package/network/ifenslave/ifenslave.cVerification
Automated security fix by OrbisAI Security