Import node fs and path functions directly

Author: ryangoree

packages/cli-menu/src/command-prompt.ts

@@ -1,5 +1,5 @@
-import fs from 'node:fs';
-import path from 'node:path';
+import { readdirSync } from 'node:fs';
+import { dirname, join } from 'node:path';
 import {
   Client,
   type CommandModule,
@@ -68,15 +68,15 @@ export async function commandPrompt(
     });
   }
 
-  const commandDirItems = fs.readdirSync(commandsDir);
+  const commandDirItems = readdirSync(commandsDir);
   const choicesByName = new Map<string, Choice>();
 
   for (const filename of commandDirItems) {
     const commandName = removeFileExtension(filename);
     let description: string | undefined;
 
     if (showDescriptions) {
-      const filepath = path.join(commandsDir, filename);
+      const filepath = join(commandsDir, filename);
       const { default: command }: { default: CommandModule } = await import(
         filepath
       ).catch(() => {
@@ -131,7 +131,7 @@ export async function commandPrompt(
     return await commandPrompt({
       ...options,
       title: undefined,
-      commandsDir: path.dirname(lastCommand.commandPath),
+      commandsDir: dirname(lastCommand.commandPath),
       selectionHistory,
     });
   }

packages/cli/src/utils/testing/command-modules.ts

@@ -1,4 +1,4 @@
-import path from 'node:path';
+import { basename, dirname, join } from 'node:path';
 import type { CommandModule } from 'src/core/command';
 import { NotFoundError } from 'src/core/errors';
 import { parseCommand } from 'src/core/parse';
@@ -79,7 +79,7 @@ vi.mock('node:fs', async (importOriginal) => {
 export function unmockAllCommandModules() {
   for (const [commandDir, commandNames] of mockCommandDirs.entries()) {
     for (const commandName of commandNames) {
-      vi.doMock(path.join(commandDir, commandName), () => {
+      vi.doMock(join(commandDir, commandName), () => {
         const mod = {
           handler: vi.fn(() => {
             throw new NotFoundError(commandName, commandDir);
@@ -111,8 +111,8 @@ export function mockCommandModule<T extends CommandModule | undefined>(
   unmock: () => void;
 } {
   const formattedFilePath = formatFileName(commandPath);
-  const commandDir = path.dirname(commandPath);
-  const commandName = path.basename(commandPath);
+  const commandDir = dirname(commandPath);
+  const commandName = basename(commandPath);
 
   // Keep track of the command directories and names that have been mocked
   if (mockCommandDirs.has(commandDir)) {
@@ -184,7 +184,7 @@ export function mockCommandStringModules<TCommandString extends string>(
 
   // mock each command in the command string
   for (const token of tokens) {
-    commandPath = path.join(commandPath, token);
+    commandPath = join(commandPath, token);
     const { mock, unmock } = mockCommandModule(commandPath, {
       handler: vi.fn(({ next, data }) => next(data)),
     });