Regenerate session id after login#668
Open
darshan-Jahagirdar wants to merge 1 commit into
Open
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 614 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #537.
This mitigates session fixation by regenerating the PHP session ID after the user credentials have been accepted and the login token has been saved, before writing the authenticated
fcms_id/fcms_tokenvalues into$_SESSION.Bounty: targets the $15 Bountysource bounty linked from #537.
Verification:
D:\income-bounty-work\tools\php-8.4.21\php.exe -l familyconnections\inc\utils.phpgit diff --cached --checkpassed before commit.Note: I could not run the legacy Test-More harness on this Windows/PHP 8.4 setup because the bundled
tests/lib/test-more.phpuses$thisas a function parameter, which PHP 8 rejects before tests can run.