Skip to content

chore: don't enforce cz#29

Open
Atry wants to merge 1 commit into
ryansonshine:mainfrom
Atry:patch-1
Open

chore: don't enforce cz#29
Atry wants to merge 1 commit into
ryansonshine:mainfrom
Atry:patch-1

Conversation

@Atry

@Atry Atry commented Jan 16, 2023

Copy link
Copy Markdown
Contributor

Description of change

As a template repository, commitizen should be optional.

Also the cz hook prevents git rebase, which is a more common command than cz. See commitizen/cz-cli#672 (comment)

Pull-Request Checklist

  • Code is up-to-date with the main branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions outlined in the conventional commit spec

As a template repository, commitizen should be optional.

Also the `cz` hook prevents `git rebase`, which is more common command than `cz`. See commitizen/cz-cli#672 (comment)
@codecov

codecov Bot commented Jan 16, 2023

Copy link
Copy Markdown

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (abf8cb8) compared to base (4fe79a6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #29   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            1         1           
  Branches         1         1           
=========================================
  Hits             1         1           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant