Feat pypi publish#192
Merged
Merged
Conversation
Contributor
Reviewer's GuideConfigures automated publishing of the cli-surf package to PyPI on GitHub release creation and slightly refines the package metadata keywords. Sequence diagram for GitHub release triggered PyPI publish workflowsequenceDiagram
actor Maintainer
participant GitHub
participant ActionsRunner
participant PyPI
Maintainer->>GitHub: Create_release(tag, notes)
GitHub-->>GitHub: Trigger_release_created_event
GitHub->>ActionsRunner: Start_workflow(publish.yml)
ActionsRunner->>ActionsRunner: actions_checkout_v4
ActionsRunner->>ActionsRunner: actions_setup_python_v4(python_3_x)
ActionsRunner->>ActionsRunner: pip_install(build, setuptools, wheel)
ActionsRunner->>ActionsRunner: python_m_build(build_distributions)
ActionsRunner->>PyPI: gh_action_pypi_publish(upload_distributions)
PyPI-->>ActionsRunner: Publish_result
ActionsRunner-->>GitHub: Workflow_status(success_or_failure)
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In the workflow environment config, the PyPI URL should use the standard
/project/cli-surf/path instead of/p/cli-surfto point to the correct project page. - You can simplify the dependency installation step to a single command (e.g.,
python -m pip install --upgrade pip build setuptools wheel) to reduce redundancy and slightly speed up the workflow.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In the workflow environment config, the PyPI URL should use the standard `/project/cli-surf/` path instead of `/p/cli-surf` to point to the correct project page.
- You can simplify the dependency installation step to a single command (e.g., `python -m pip install --upgrade pip build setuptools wheel`) to reduce redundancy and slightly speed up the workflow.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General:
Code:
Summary by Sourcery
Configure automated publishing of the Python package to PyPI when a GitHub release is created.
Build: