fix: correct content-type for HTML pages and allow password-less redis#418
Merged
ryo-ma merged 2 commits intoMar 4, 2026
Merged
Conversation
Set Content-Type to 'text/html' instead of 'text' for index and error page responses, since both return HTML content. Also change redis username/password fallback from empty string to undefined so that the driver skips AUTH when no credentials are configured. An empty string causes AUTH to be sent which fails on servers with no password set. Fixes #387, fixes #388
|
@sehawq is attempting to deploy a commit to the ryo-ma's Team Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
CI failed. Please confirm. |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Hi @ryo-ma, thanks for flagging the CI failure. The issue was an unintended formatting change (\ instead of ) that caused \ to fail. I've pushed a fix — the CI should pass now. |
ryo-ma
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two separate issues:
Content-Type (#387)
The index page and error page responses set
Content-Type: "text"butboth return HTML content. Changed to
text/htmlso browsers render themproperly.
Redis auth (#388)
When
REDIS_PASSWORDis not set, the fallback empty string ("") causesthe driver to send
AUTH ""which fails on servers configured without apassword. Changed the fallback to
undefinedso the driver skips AUTHentirely when no credentials are provided. Same fix applied to
REDIS_USERNAME.Fixes #387, fixes #388