Skip to content

Commit 7cc167f

Browse files
authored
Remove deprecated integration classes (#1343)
The following previously deprecated classes exist no more: * AirFreshVA4 - use AirFresh * AirHumidifierCA1, AirHumidifierCB1, AirHumidifierCB2 - use AirHumidifier * AirDogX5, AirDogX7SM - use AirDogX3 * AirPurifierMB4 - use AirPurifierMiot * Plug, PlugV1, PlugV3 - use ChuangmiPlug * FanP9, FanP10, FanP11 - use FanMiot * DreameVacuumMiot - use DreameVacuum * Vacuum - use RoborockVacuum
1 parent b8b9c1a commit 7cc167f

15 files changed

Lines changed: 24 additions & 230 deletions

miio/__init__.py

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -21,28 +21,28 @@
2121
)
2222
from miio.airconditioningcompanionMCN import AirConditioningCompanionMcn02
2323
from miio.airdehumidifier import AirDehumidifier
24-
from miio.airfresh import AirFresh, AirFreshVA4
24+
from miio.airfresh import AirFresh
2525
from miio.airfresh_t2017 import AirFreshA1, AirFreshT2017
26-
from miio.airhumidifier import AirHumidifier, AirHumidifierCA1, AirHumidifierCB1
26+
from miio.airhumidifier import AirHumidifier
2727
from miio.airhumidifier_jsq import AirHumidifierJsq
2828
from miio.airhumidifier_miot import AirHumidifierMiot
2929
from miio.airhumidifier_mjjsq import AirHumidifierMjjsq
3030
from miio.airpurifier import AirPurifier
31-
from miio.airpurifier_airdog import AirDogX3, AirDogX5, AirDogX7SM
32-
from miio.airpurifier_miot import AirPurifierMB4, AirPurifierMiot
31+
from miio.airpurifier_airdog import AirDogX3
32+
from miio.airpurifier_miot import AirPurifierMiot
3333
from miio.airqualitymonitor import AirQualityMonitor
3434
from miio.airqualitymonitor_miot import AirQualityMonitorCGDN1
3535
from miio.aqaracamera import AqaraCamera
3636
from miio.chuangmi_camera import ChuangmiCamera
3737
from miio.chuangmi_ir import ChuangmiIr
38-
from miio.chuangmi_plug import ChuangmiPlug, Plug, PlugV1, PlugV3
38+
from miio.chuangmi_plug import ChuangmiPlug
3939
from miio.cooker import Cooker
4040
from miio.curtain_youpin import CurtainMiot
4141
from miio.gateway import Gateway
4242
from miio.heater import Heater
4343
from miio.heater_miot import HeaterMiot
4444
from miio.huizuo import Huizuo, HuizuoLampFan, HuizuoLampHeater, HuizuoLampScene
45-
from miio.integrations.fan.dmaker import Fan1C, FanMiot, FanP5, FanP9, FanP10, FanP11
45+
from miio.integrations.fan.dmaker import Fan1C, FanMiot, FanP5
4646
from miio.integrations.fan.leshow import FanLeshow
4747
from miio.integrations.fan.zhimi import Fan, FanZA5
4848
from miio.integrations.humidifier.deerma import AirHumidifierJsqs
@@ -55,12 +55,9 @@
5555
PhilipsWhiteBulb,
5656
)
5757
from miio.integrations.petwaterdispenser import PetWaterDispenser
58-
from miio.integrations.vacuum.dreame.dreamevacuum_miot import (
59-
DreameVacuum,
60-
DreameVacuumMiot,
61-
)
58+
from miio.integrations.vacuum.dreame.dreamevacuum_miot import DreameVacuum
6259
from miio.integrations.vacuum.mijia import G1Vacuum
63-
from miio.integrations.vacuum.roborock import RoborockVacuum, Vacuum, VacuumException
60+
from miio.integrations.vacuum.roborock import RoborockVacuum, VacuumException
6461
from miio.integrations.vacuum.roborock.vacuumcontainers import (
6562
CleaningDetails,
6663
CleaningSummary,

miio/airfresh.py

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
from .click_common import EnumType, command, format_output
99
from .device import Device, DeviceStatus
1010
from .exceptions import DeviceException
11-
from .utils import deprecated
1211

1312
_LOGGER = logging.getLogger(__name__)
1413

@@ -348,22 +347,3 @@ def set_ptc(self, ptc: bool):
348347
return self.send("set_ptc_state", ["on"])
349348
else:
350349
return self.send("set_ptc_state", ["off"])
351-
352-
353-
@deprecated(
354-
"This will be removed in the future, use AirFresh(..., model='zhimi.airfresh.va4'"
355-
)
356-
class AirFreshVA4(AirFresh):
357-
"""Main class representing the air fresh va4."""
358-
359-
def __init__(
360-
self,
361-
ip: str = None,
362-
token: str = None,
363-
start_id: int = 0,
364-
debug: int = 0,
365-
lazy_discover: bool = True,
366-
) -> None:
367-
super().__init__(
368-
ip, token, start_id, debug, lazy_discover, model=MODEL_AIRFRESH_VA4
369-
)

miio/airhumidifier.py

Lines changed: 0 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
from .click_common import EnumType, command, format_output
99
from .device import Device, DeviceInfo, DeviceStatus
1010
from .exceptions import DeviceError, DeviceException
11-
from .utils import deprecated
1211

1312
_LOGGER = logging.getLogger(__name__)
1413

@@ -405,48 +404,3 @@ def set_dry(self, dry: bool):
405404
return self.send("set_dry", ["on"])
406405
else:
407406
return self.send("set_dry", ["off"])
408-
409-
410-
@deprecated("Use AirHumidifer(model='zhimi.humidifier.ca1")
411-
class AirHumidifierCA1(AirHumidifier):
412-
def __init__(
413-
self,
414-
ip: str = None,
415-
token: str = None,
416-
start_id: int = 0,
417-
debug: int = 0,
418-
lazy_discover: bool = True,
419-
) -> None:
420-
super().__init__(
421-
ip, token, start_id, debug, lazy_discover, model=MODEL_HUMIDIFIER_CA1
422-
)
423-
424-
425-
@deprecated("Use AirHumidifer(model='zhimi.humidifier.cb1")
426-
class AirHumidifierCB1(AirHumidifier):
427-
def __init__(
428-
self,
429-
ip: str = None,
430-
token: str = None,
431-
start_id: int = 0,
432-
debug: int = 0,
433-
lazy_discover: bool = True,
434-
) -> None:
435-
super().__init__(
436-
ip, token, start_id, debug, lazy_discover, model=MODEL_HUMIDIFIER_CB1
437-
)
438-
439-
440-
@deprecated("Use AirHumidifier(model='zhimi.humidifier.cb2')")
441-
class AirHumidifierCB2(AirHumidifier):
442-
def __init__(
443-
self,
444-
ip: str = None,
445-
token: str = None,
446-
start_id: int = 0,
447-
debug: int = 0,
448-
lazy_discover: bool = True,
449-
) -> None:
450-
super().__init__(
451-
ip, token, start_id, debug, lazy_discover, model=MODEL_HUMIDIFIER_CB2
452-
)

miio/airpurifier_airdog.py

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
from .click_common import EnumType, command, format_output
99
from .device import Device, DeviceStatus
1010
from .exceptions import DeviceException
11-
from .utils import deprecated
1211

1312
_LOGGER = logging.getLogger(__name__)
1413

@@ -177,31 +176,3 @@ def set_child_lock(self, lock: bool):
177176
def set_filters_cleaned(self):
178177
"""Set filters cleaned."""
179178
return self.send("set_clean")
180-
181-
182-
class AirDogX5(AirDogX3):
183-
@deprecated("Use AirDogX3(model='airdog.airpurifier.x5')")
184-
def __init__(
185-
self,
186-
ip: str = None,
187-
token: str = None,
188-
start_id: int = 0,
189-
debug: int = 0,
190-
lazy_discover: bool = True,
191-
model: str = MODEL_AIRDOG_X5,
192-
) -> None:
193-
super().__init__(ip, token, start_id, debug, lazy_discover, model=model)
194-
195-
196-
class AirDogX7SM(AirDogX3):
197-
@deprecated("Use AirDogX3(model='airdog.airpurifier.x7sm')")
198-
def __init__(
199-
self,
200-
ip: str = None,
201-
token: str = None,
202-
start_id: int = 0,
203-
debug: int = 0,
204-
lazy_discover: bool = True,
205-
model: str = MODEL_AIRDOG_X7SM,
206-
) -> None:
207-
super().__init__(ip, token, start_id, debug, lazy_discover, model=model)

miio/airpurifier_miot.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44

55
import click
66

7-
from miio.utils import deprecated
8-
97
from .airfilter_util import FilterType, FilterTypeUtil
108
from .click_common import EnumType, command, format_output
119
from .exceptions import DeviceException
@@ -545,9 +543,3 @@ def set_led_brightness_level(self, level: int):
545543
raise AirPurifierMiotException("Invalid brightness level: %s" % level)
546544

547545
return self.set_property("led_brightness_level", level)
548-
549-
550-
class AirPurifierMB4(AirPurifierMiot):
551-
@deprecated("Use AirPurifierMiot")
552-
def __init__(*args, **kwargs):
553-
super().__init__(*args, **kwargs)

miio/chuangmi_plug.py

Lines changed: 0 additions & 56 deletions
Original file line numberDiff line numberDiff line change
@@ -173,59 +173,3 @@ def set_led(self, wifi_led: bool):
173173
return self.send("set_wifi_led", ["on"])
174174
else:
175175
return self.send("set_wifi_led", ["off"])
176-
177-
178-
@deprecated(
179-
"This device class is deprecated. Please use the ChuangmiPlug "
180-
"class in future and select a model by parameter 'model'."
181-
)
182-
class Plug(ChuangmiPlug):
183-
def __init__(
184-
self,
185-
ip: str = None,
186-
token: str = None,
187-
start_id: int = 0,
188-
debug: int = 0,
189-
lazy_discover: bool = True,
190-
*,
191-
model: str = None
192-
) -> None:
193-
super().__init__(
194-
ip, token, start_id, debug, lazy_discover, model=MODEL_CHUANGMI_PLUG_M1
195-
)
196-
197-
198-
@deprecated(
199-
"This device class is deprecated. Please use the ChuangmiPlug "
200-
"class in future and select a model by parameter 'model'."
201-
)
202-
class PlugV1(ChuangmiPlug):
203-
def __init__(
204-
self,
205-
ip: str = None,
206-
token: str = None,
207-
start_id: int = 0,
208-
debug: int = 0,
209-
lazy_discover: bool = True,
210-
) -> None:
211-
super().__init__(
212-
ip, token, start_id, debug, lazy_discover, model=MODEL_CHUANGMI_PLUG_V1
213-
)
214-
215-
216-
@deprecated(
217-
"This device class is deprecated. Please use the ChuangmiPlug "
218-
"class in future and select a model by parameter 'model'."
219-
)
220-
class PlugV3(ChuangmiPlug):
221-
def __init__(
222-
self,
223-
ip: str = None,
224-
token: str = None,
225-
start_id: int = 0,
226-
debug: int = 0,
227-
lazy_discover: bool = True,
228-
) -> None:
229-
super().__init__(
230-
ip, token, start_id, debug, lazy_discover, model=MODEL_CHUANGMI_PLUG_V3
231-
)

miio/discovery.py

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@
1515
AirConditioningCompanion,
1616
AirConditioningCompanionMcn02,
1717
AirDogX3,
18-
AirDogX5,
19-
AirDogX7SM,
2018
AirFresh,
2119
AirFreshT2017,
2220
AirHumidifier,
@@ -43,8 +41,8 @@
4341
PhilipsRwread,
4442
PhilipsWhiteBulb,
4543
PowerStrip,
44+
RoborockVacuum,
4645
Toiletlid,
47-
Vacuum,
4846
ViomiVacuum,
4947
WaterPurifier,
5048
WaterPurifierYunmi,
@@ -89,10 +87,10 @@
8987

9088

9189
DEVICE_MAP: Dict[str, Union[Type[Device], partial]] = {
92-
"rockrobo-vacuum-v1": Vacuum,
93-
"roborock-vacuum-s5": Vacuum,
94-
"roborock-vacuum-m1s": Vacuum,
95-
"roborock-vacuum-a10": Vacuum,
90+
"rockrobo-vacuum-v1": RoborockVacuum,
91+
"roborock-vacuum-s5": RoborockVacuum,
92+
"roborock-vacuum-m1s": RoborockVacuum,
93+
"roborock-vacuum-a10": RoborockVacuum,
9694
"chuangmi-plug-m1": partial(ChuangmiPlug, model=MODEL_CHUANGMI_PLUG_M1),
9795
"chuangmi-plug-m3": partial(ChuangmiPlug, model=MODEL_CHUANGMI_PLUG_M3),
9896
"chuangmi-plug-v1": partial(ChuangmiPlug, model=MODEL_CHUANGMI_PLUG_V1),
@@ -109,8 +107,8 @@
109107
"xiaomi.aircondition.mc4": AirConditionerMiot,
110108
"xiaomi.aircondition.mc5": AirConditionerMiot,
111109
"airdog-airpurifier-x3": AirDogX3,
112-
"airdog-airpurifier-x5": AirDogX5,
113-
"airdog-airpurifier-x7sm": AirDogX7SM,
110+
"airdog-airpurifier-x5": AirDogX3,
111+
"airdog-airpurifier-x7sm": AirDogX3,
114112
"zhimi-airpurifier-m1": AirPurifier, # mini model
115113
"zhimi-airpurifier-m2": AirPurifier, # mini model 2
116114
"zhimi-airpurifier-ma1": AirPurifier, # ms model
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
# flake8: noqa
22
from .fan import FanP5
3-
from .fan_miot import Fan1C, FanMiot, FanP9, FanP10, FanP11
3+
from .fan_miot import Fan1C, FanMiot

miio/integrations/fan/dmaker/fan_miot.py

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
from miio import DeviceStatus, MiotDevice
77
from miio.click_common import EnumType, command, format_output
88
from miio.fan_common import FanException, MoveDirection, OperationMode
9-
from miio.utils import deprecated
109

1110
MODEL_FAN_P9 = "dmaker.fan.p9"
1211
MODEL_FAN_P10 = "dmaker.fan.p10"
@@ -371,21 +370,6 @@ def set_rotate(self, direction: MoveDirection):
371370
return self.set_property("set_move", value)
372371

373372

374-
@deprecated("Use FanMiot")
375-
class FanP9(FanMiot):
376-
mapping = MIOT_MAPPING[MODEL_FAN_P9]
377-
378-
379-
@deprecated("Use FanMiot")
380-
class FanP10(FanMiot):
381-
mapping = MIOT_MAPPING[MODEL_FAN_P10]
382-
383-
384-
@deprecated("Use FanMiot")
385-
class FanP11(FanMiot):
386-
mapping = MIOT_MAPPING[MODEL_FAN_P11]
387-
388-
389373
class Fan1C(MiotDevice):
390374
mapping = MIOT_MAPPING[MODEL_FAN_1C]
391375

miio/integrations/vacuum/dreame/dreamevacuum_miot.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
from miio.exceptions import DeviceException
1111
from miio.miot_device import DeviceStatus as DeviceStatusContainer
1212
from miio.miot_device import MiotDevice, MiotMapping
13-
from miio.utils import deprecated
1413

1514
_LOGGER = logging.getLogger(__name__)
1615

@@ -610,9 +609,3 @@ def rotate(self, rotatation: int) -> None:
610609
},
611610
],
612611
)
613-
614-
615-
class DreameVacuumMiot(DreameVacuum):
616-
@deprecated("DreameVacuumMiot is deprectaed. Use DreameVacuum instead.")
617-
def __init__(self, *args, **kwargs):
618-
super().__init__(*args, **kwargs)

0 commit comments

Comments
 (0)