This repository was archived by the owner on Dec 1, 2019. It is now read-only.
Fix: Add hack to stop null exception#337
Open
DanielFallon wants to merge 1 commit into
Open
Conversation
Creating a fix based on s-panferov#190 I have not tested this fix, I'm contributing it for evaluation
mblandfo
reviewed
Jan 24, 2017
| function applyDefaults(configFilePath: string, compilerConfig: TsConfig, loaderConfig: LoaderConfig) { | ||
| // HACK: adding in a blank initializer to stop loader from crashing, | ||
| // see s-panferov/awesome-typescript-loader#190 for more details | ||
| compilerConfig.raw.compilerOptions.exclude = compilerConfig.raw.compilerOptions.exclude || []; |
There was a problem hiding this comment.
I think the crash was in 2.2.4 and not in master so this fix doesn't apply. The line that was crashing isn't even here: compilerConfig.typingOptions.exclude = compilerConfig.typingOptions.exclude || [];
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In lieu of overall rewrites, there is a crash with a null reference error.
Adding fix suggested by @sdudziak to deal with this in the short term (see #190 for more details)
A larger rewrite will be necesary to deal with Webpack 2 and typescript 2.1