feat(form elements): improve input, textarea, select#4371
Merged
Conversation
- use size and font based on variables - remove redundant rules - fix input shadow element settings to work when using `.input input` and `input.input` - fix placeholder color for safari Notable changes: - `.floating-label` is `flex` instead of `block` so that we can keep input `inline-flex` and avoid white space generated spacing - input is `relative` so that the `::-webkit-calendar-picker-indicator` is correctly positioned when using `.input input` example (only for input): https://play.tailwindcss.com/s2xaEB1VZw?file=css close saadeghi#4370
…x replacement exclude for `--size-`
- set the variables from children because `.floating-label` does not have much reason to be responsive
|
Nice, would love to see this merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.input inputandinput.input.floating-labelrespect responsive size modifiers on child.input,.select,.textareaNotable changes:
.floating-labelisflexinstead ofblockso that we can keep inputinline-flexand avoid white space generated spacingrelativeso that the::-webkit-calendar-picker-indicatoris correctly positioned when using.input inputNot solved:
.floating-labeldoes not adapt to responsive size classes of content (TODO in future PR)example (only for input): https://play.tailwindcss.com/s2xaEB1VZw?file=css
close #4370