ci(repo): fix CodeQL workflow - Rust needs build-mode none#45
Merged
Conversation
Two bugs introduced by the original CodeQL workflow in Wave 3 (#30), each caught on first master run after merge: 1. Rust matrix used build-mode: manual. CodeQL's Rust support does not accept manual mode — the init step hard-fails with 'A fatal error occurred: Rust does not support the manual build mode. Please try using one of the following build modes instead: none.' Fix: use build-mode: none. Also drop the now-unused 'Build Rust (manual mode)' + 'Install Rust' steps. 2. JS matrix passed cache: 'pnpm' to actions/setup-node. With build-mode: none we never run pnpm install, so the cache post-step tries to save a cache from a nonexistent path and fails with 'Path(s) specified in the action for caching do(es) not exist'. Fix: drop the cache param for CodeQL (we don't install anything). Also drop the pnpm/action-setup step — unused after the cache removal. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix two bugs in
.github/workflows/codeql.ymlthat I introduced in Wave 3 (#30) and that caused both matrix jobs to fail on every run since.Change 1: Rust matrix
build-mode: manual→build-mode: none. CodeQL's Rust support hard-rejects manual mode with:Change 2: Drop
cache: "pnpm"fromactions/setup-nodeon the JS matrix. Withbuild-mode: nonewe never runpnpm install, so the cache post-step tries to save from a nonexistent path and fails with:Also drop the now-unused
Install Rust,Setup pnpm, andBuild Rust (manual mode)steps.Why
Caught these while verifying the post-Wave-4 state before Wave 5. The bugs have been failing on every master push since #30 landed (both matrix jobs red). No SARIF uploaded, so the Security tab has nothing to show.
With this fix, CodeQL will actually run — which was the whole point of Wave 3.
How
One commit. 6 insertions, 24 deletions. No other workflows touched.
Testing
js-yaml(OK); matrix inspected (two entries, bothbuild-mode: none)Perform CodeQL Analysisand upload SARIFPerformance impact
Risk / Notes
Screenshots (UI only)
Lockfile rationale (if lockfile changed)
🤖 Generated with Claude Code