refactor(components): extract useDraftGeneration hook (Wave 5.7 Phase A complete)#55
Merged
Merged
Conversation
Move the final Phase A concern — streaming response generation + alternatives lifecycle — out of DraftTab.tsx into a dedicated hook. Hook owns generating/generatingAlternative flags and the firstDraftStartMsRef time-to-draft tracker; accepts setters for the response/sources/metrics/confidence/grounding state that remains in the shell, since those are read by many non-generation handlers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Extracts the final Phase A hook, `useDraftGeneration`, from `src/components/Draft/DraftTab.tsx`. Completes the Wave 5.7 hook decomposition:
File size: 2283 → 2138 LOC (-145 on this PR; -435 total across both PRs from original 2573, ~17% reduction).
Why
`handleGenerate` + `handleGenerateAlternative` + `handleChooseAlternative` + `handleUseAlternative` form one cohesive concern: streaming LLM response generation and the alternatives lifecycle. The hook owns the two loading flags (`generating`, `generatingAlternative`) and the `firstDraftStartMsRef` time-to-draft tracker, accepting setters for the response-content state (`response`, `sources`, `metrics`, `confidence`, `grounding`, `originalResponse`, `isResponseEdited`) that stays in the shell because many non-generation handlers also write those fields.
How
Deferred to a follow-up PR
Testing
Risk / Notes