fix(components): inject tauri calls into useResponseActions#62
Merged
Conversation
The useResponseActions hook was calling invoke() directly from tauri for audit_response_copy_override and export_draft, breaking the pure-hook contract that the other 12 Wave 5.7 hooks follow. Move the two invoke wrappers into a new draftTauriCommands module and inject them as hook options. Test no longer needs to vi.mock the entire @tauri-apps/api/core module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Small purity fix for `useResponseActions` — the last Wave 5.7 hook that was calling tauri's `invoke` directly from inside its body. The 12 other extracted hooks take their side-effect dependencies as injected options; this PR brings `useResponseActions` onto the same contract.
Why
Caught by the post-Wave-5 verification audit. The hook mixed pure React state with two direct tauri calls (`audit_response_copy_override` and `export_draft`). That meant:
How
Testing
Risk / Notes