chore(codeql): clean up dead-code alerts

- Replace placeholder protocol bodies and stale state assignments
- Remove unused locals and strengthen tests that ignored return values

Tests: python3 -m pytest -q -p no:cacheprovider; ruff check src/ tests/

Author: saagpatel

scripts/add_licenses.py

@@ -156,7 +156,6 @@ def process_repo(target: RepoTarget, headers: dict, dry_run: bool) -> tuple[str,
             return name, "skipped (license exists)"
 
         if dry_run:
-            license_text = build_mit_license(target.created_year)
             year_range = str(target.created_year) if target.created_year == CURRENT_YEAR else f"{target.created_year}-{CURRENT_YEAR}"
             return name, f"dry-run (would add LICENSE, copyright {year_range})"
 

src/analyzers/base.py

@@ -22,7 +22,8 @@ def analyze(
         repo_path: Path,
         metadata: RepoMetadata,
         github_client: GitHubClient | None = None,
-    ) -> AnalyzerResult: ...
+    ) -> AnalyzerResult:
+        raise NotImplementedError
 
     def cache_inputs_hash(
         self,

src/analyzers/community_profile.py

@@ -40,7 +40,6 @@ def analyze(
         metadata: RepoMetadata,
         github_client: GitHubClient | None = None,
     ) -> AnalyzerResult:
-        score = 0.0
         findings: list[str] = []
         details: dict = {}
 

src/cli.py

@@ -53,7 +53,7 @@
 from src.terminology import ACTION_SYNC_CANONICAL_LABELS
 
 # Emitted at most once per process when legacy flat invocation is used.
-_LEGACY_WARNING_EMITTED: bool = False
+_LEGACY_WARNING_EVENTS: set[str] = set()
 
 DEFAULT_ANALYSIS_WORKERS = 1
 MAX_ANALYSIS_WORKERS = 8
@@ -6533,10 +6533,9 @@ def _infer_subcommand_from_flags(args: argparse.Namespace) -> str:
 
 def _emit_legacy_deprecation_warning(inferred: str) -> None:
     """Emit the deprecation warning at most once per process."""
-    global _LEGACY_WARNING_EMITTED
-    if _LEGACY_WARNING_EMITTED:
+    if "legacy-cli" in _LEGACY_WARNING_EVENTS:
         return
-    _LEGACY_WARNING_EMITTED = True
+    _LEGACY_WARNING_EVENTS.add("legacy-cli")
     warnings.warn(
         f"Top-level CLI invocation is deprecated. "
         f"Use `audit {inferred} --flag` instead. "

src/maturity_tiers.py

@@ -312,11 +312,8 @@ def _check_silver(repo: dict) -> list[str]:
 def _check_gold(repo: dict) -> list[str]:
     """Return list of unmet Gold requirements (beyond Silver)."""
     derived = repo.get("derived") or {}
-    risk = repo.get("risk") or {}
     if not isinstance(derived, dict):
         derived = {}
-    if not isinstance(risk, dict):
-        risk = {}
 
     missing: list[str] = []
 
@@ -418,11 +415,8 @@ def _check_gold_with_sources(
 ) -> tuple[list[str], list[Literal["strict", "proxy"]]]:
     """Like _check_gold but also returns parallel source annotations."""
     derived = repo.get("derived") or {}
-    risk = repo.get("risk") or {}
     if not isinstance(derived, dict):
         derived = {}
-    if not isinstance(risk, dict):
-        risk = {}
 
     missing: list[str] = []
     sources: list[Literal["strict", "proxy"]] = []

src/narrative.py

@@ -25,7 +25,8 @@
 
 
 class NarrativeProvider(Protocol):
-    def generate(self, prompt: str, model: str, max_tokens: int) -> str: ...
+    def generate(self, prompt: str, model: str, max_tokens: int) -> str:
+        raise NotImplementedError
 
 
 # ── Anthropic provider ───────────────────────────────────────────────────────

src/operator_resolution_trend.py

@@ -19316,9 +19316,6 @@ def _class_trust_momentum_for_target(
     if class_normalization_status == "applied" and momentum_status in {"reversing", "unstable"}:
         softened_reason = "Recent class evidence is changing direction, so earlier class normalization is being softened back to candidate."
         reverted_policy = target.get("pre_class_normalization_trust_policy", trust_policy)
-        reverted_reason = target.get(
-            "pre_class_normalization_trust_policy_reason", trust_policy_reason
-        )
         if trust_policy == "act-with-review" and reverted_policy == "verify-first":
             trust_policy = reverted_policy
             trust_policy_reason = softened_reason

src/semantic_index.py

@@ -62,7 +62,8 @@ class Embedder(Protocol):
     name: str
     dimension: int
 
-    def embed(self, texts: list[str]) -> list[list[float]]: ...
+    def embed(self, texts: list[str]) -> list[list[float]]:
+        raise NotImplementedError
 
 
 # ---------------------------------------------------------------------------

tests/test_analyzer_cache.py

@@ -364,10 +364,11 @@ def counting_analyze(repo_path, metadata, github_client=None, **kwargs):
         # First run — should call analyze() and populate cache.
         r1 = run_with_cache(analyzer, repo, meta, None, sha, conn)
         assert call_count == 1
+        first_run_count = call_count
 
         # Second run — should hit cache and NOT call analyze() again.
         r2 = run_with_cache(analyzer, repo, meta, None, sha, conn)
-        assert call_count == 1  # still 1!
+        assert call_count == first_run_count
 
         assert r1.dimension == r2.dimension
         assert r1.score == r2.score

tests/test_cli_subcommands.py

@@ -127,24 +127,24 @@ def test_legacy_rewriter_leaves_serve_flag_unchanged(self):
         assert is_legacy is False
 
     def test_legacy_emits_deprecation_warning(self):
-        cli_module._LEGACY_WARNING_EMITTED = False
+        cli_module._LEGACY_WARNING_EVENTS.clear()
         with warnings.catch_warnings(record=True) as caught:
             warnings.simplefilter("always")
             cli_module._emit_legacy_deprecation_warning("run")
         assert any(issubclass(w.category, DeprecationWarning) for w in caught)
         assert any("audit run" in str(w.message) for w in caught)
-        cli_module._LEGACY_WARNING_EMITTED = False
+        cli_module._LEGACY_WARNING_EVENTS.clear()
 
     def test_legacy_warning_emits_once(self):
-        cli_module._LEGACY_WARNING_EMITTED = False
+        cli_module._LEGACY_WARNING_EVENTS.clear()
         with warnings.catch_warnings(record=True) as caught:
             warnings.simplefilter("always")
             cli_module._emit_legacy_deprecation_warning("run")
             cli_module._emit_legacy_deprecation_warning("run")
             cli_module._emit_legacy_deprecation_warning("triage")
         deprecations = [w for w in caught if issubclass(w.category, DeprecationWarning)]
         assert len(deprecations) == 1
-        cli_module._LEGACY_WARNING_EMITTED = False
+        cli_module._LEGACY_WARNING_EVENTS.clear()
 
     def test_legacy_skip_forks(self):
         args = _parse_legacy("myuser", "--skip-forks")