test: stabilize approval loader fixtures

Author: saagpatel

tests/test_cli_hardening.py

@@ -125,7 +125,7 @@ def __init__(self, args: Namespace) -> None:
         self.args = args
         self.error_message: str | None = None
 
-    def parse_args(self) -> Namespace:
+    def parse_args(self, args=None) -> Namespace:
         return self.args
 
     def error(self, message: str) -> None:

tests/test_draft_readmes.py

@@ -4,6 +4,7 @@
 
 import tempfile
 import warnings
+from datetime import datetime, timezone
 from pathlib import Path
 from typing import Any
 from unittest.mock import MagicMock, patch
@@ -25,6 +26,10 @@
 # ── Helpers ───────────────────────────────────────────────────────────────────
 
 
+def _recent_generated_at() -> str:
+    return datetime.now(timezone.utc).isoformat()
+
+
 def _make_repo(
     name: str = "my-repo",
     *,
@@ -512,7 +517,7 @@ def _make_approved_packet(
     repo_name: str = "my-repo",
     *,
     status: str = "approved-manual",
-    generated_at: str = "2026-05-11T10:00:00+00:00",
+    generated_at: str | None = None,
     proposed_readme: str = "# My Repo\n\nA great project.",
 ) -> DraftReadmePacket:
     return DraftReadmePacket(
@@ -523,7 +528,7 @@ def _make_approved_packet(
         llm_provider="fake",
         llm_model="fake-model",
         llm_cost_usd=0.001,
-        generated_at=generated_at,
+        generated_at=generated_at or _recent_generated_at(),
         context_repos=[],
     )
 

tests/test_per_action_approval.py

@@ -4,6 +4,7 @@
 
 import json
 import tempfile
+from datetime import datetime, timezone
 from pathlib import Path
 
 import pytest
@@ -22,12 +23,17 @@
 # ---------------------------------------------------------------------------
 
 
+def _recent_generated_at() -> str:
+    return datetime.now(timezone.utc).isoformat()
+
+
 def _make_packet(
     goal: str = "add CI to all repos",
     *,
     num_actions: int = 2,
-    generated_at: str = "2026-05-12T00:00:00+00:00",
+    generated_at: str | None = None,
 ) -> CampaignPlanPacket:
+    generated_at = generated_at or _recent_generated_at()
     actions = [
         CampaignAction(
             repo_name=f"repo-{i}",
@@ -215,6 +221,7 @@ def test_load_approved_campaign_plans_defaults_missing_state_to_pending(self) ->
 
         with tempfile.TemporaryDirectory() as tmp:
             output_dir = Path(tmp)
+            generated_at = _recent_generated_at()
             # Write a record whose actions have NO 'state' field
             save_approval_record(
                 output_dir,
@@ -224,7 +231,7 @@ def test_load_approved_campaign_plans_defaults_missing_state_to_pending(self) ->
                     "approval_subject_type": "campaign-plan",
                     "subject_key": "legacykey001",
                     "source_run_id": "",
-                    "approved_at": "2026-05-12T00:00:00+00:00",
+                    "approved_at": generated_at,
                     "approved_by": "tester",
                     "approval_note": "legacy",
                     "action_type": "campaign-plan",
@@ -235,7 +242,7 @@ def test_load_approved_campaign_plans_defaults_missing_state_to_pending(self) ->
                     "llm_provider": "fake",
                     "llm_model": "m",
                     "llm_cost_usd": 0.0,
-                    "generated_at": "2026-05-12T00:00:00+00:00",
+                    "generated_at": generated_at,
                     "status": "approved-manual",
                     "actions": [
                         {
@@ -260,6 +267,7 @@ def test_load_approved_campaign_plans_preserves_existing_state(self) -> None:
 
         with tempfile.TemporaryDirectory() as tmp:
             output_dir = Path(tmp)
+            generated_at = _recent_generated_at()
             save_approval_record(
                 output_dir,
                 {
@@ -268,7 +276,7 @@ def test_load_approved_campaign_plans_preserves_existing_state(self) -> None:
                     "approval_subject_type": "campaign-plan",
                     "subject_key": "statekey002",
                     "source_run_id": "",
-                    "approved_at": "2026-05-12T00:00:00+00:00",
+                    "approved_at": generated_at,
                     "approved_by": "tester",
                     "approval_note": "state test",
                     "action_type": "campaign-plan",
@@ -279,7 +287,7 @@ def test_load_approved_campaign_plans_preserves_existing_state(self) -> None:
                     "llm_provider": "fake",
                     "llm_model": "m",
                     "llm_cost_usd": 0.0,
-                    "generated_at": "2026-05-12T00:00:00+00:00",
+                    "generated_at": generated_at,
                     "status": "approved-manual",
                     "actions": [
                         {
@@ -319,6 +327,7 @@ def _make_approved_manual_packet(
         from src.plan_campaign import _goal_subject_key, _packet_record_id
         from src.warehouse import save_approval_record
 
+        generated_at = _recent_generated_at()
         packet = CampaignPlanPacket(
             goal=goal,
             actions=actions,
@@ -327,7 +336,7 @@ def _make_approved_manual_packet(
             llm_provider="fake",
             llm_model="m",
             llm_cost_usd=0.0,
-            generated_at="2026-05-12T00:00:00+00:00",
+            generated_at=generated_at,
         )
         record_id = _packet_record_id(packet)
         actions_dicts = [
@@ -351,7 +360,7 @@ def _make_approved_manual_packet(
                 "approval_subject_type": "campaign-plan",
                 "subject_key": _goal_subject_key(goal),
                 "source_run_id": "",
-                "approved_at": "2026-05-12T00:00:00+00:00",
+                "approved_at": generated_at,
                 "approved_by": "tester",
                 "approval_note": goal,
                 "action_type": "campaign-plan",
@@ -362,7 +371,7 @@ def _make_approved_manual_packet(
                 "llm_provider": "fake",
                 "llm_model": "m",
                 "llm_cost_usd": 0.0,
-                "generated_at": "2026-05-12T00:00:00+00:00",
+                "generated_at": generated_at,
                 "status": "approved-manual",
                 "actions": actions_dicts,
             },

tests/test_per_section_draft_readmes.py

@@ -3,6 +3,7 @@
 from __future__ import annotations
 
 import tempfile
+from datetime import datetime, timezone
 from pathlib import Path
 
 import pytest
@@ -21,10 +22,14 @@
 # ── Helpers ───────────────────────────────────────────────────────────────────
 
 
+def _recent_generated_at() -> str:
+    return datetime.now(timezone.utc).isoformat()
+
+
 def _make_packet(
     repo_name: str = "test-repo",
     proposed_readme: str = "## Installation\npip install foo\n\n## Usage\nrun it\n",
-    generated_at: str = "2026-05-11T00:00:00+00:00",
+    generated_at: str | None = None,
 ) -> DraftReadmePacket:
     return DraftReadmePacket(
         repo_name=repo_name,
@@ -34,7 +39,7 @@ def _make_packet(
         llm_provider="openai",
         llm_model="gpt-4",
         llm_cost_usd=0.001,
-        generated_at=generated_at,
+        generated_at=generated_at or _recent_generated_at(),
     )
 
 
@@ -233,6 +238,7 @@ def test_legacy_records_load_via_load_approved_drafts(self) -> None:
 
         with tempfile.TemporaryDirectory() as tmp:
             output_dir = Path(tmp)
+            generated_at = _recent_generated_at()
             save_approval_record(
                 output_dir,
                 {
@@ -241,13 +247,13 @@ def test_legacy_records_load_via_load_approved_drafts(self) -> None:
                     "approval_subject_type": "draft-readme",
                     "subject_key": "legacy-repo",
                     "source_run_id": "",
-                    "approved_at": "2026-05-11T00:00:00+00:00",
+                    "approved_at": generated_at,
                     "approved_by": "tester",
                     "approval_note": "legacy",
                     "action_type": "draft-readme",
                     "target_context": "legacy-repo",
                     "decision": "",
-                    "timestamp": "2026-05-11T00:00:00+00:00",
+                    "timestamp": generated_at,
                     "status": "approved-manual",
                     "repo_name": "legacy-repo",
                     "current_readme_sha": None,
@@ -256,7 +262,7 @@ def test_legacy_records_load_via_load_approved_drafts(self) -> None:
                     "llm_provider": "openai",
                     "llm_model": "gpt-4",
                     "llm_cost_usd": 0.0,
-                    "generated_at": "2026-05-11T00:00:00+00:00",
+                    "generated_at": generated_at,
                     "context_repos": [],
                 },
             )

tests/test_plan_campaign.py

@@ -4,6 +4,7 @@
 
 import json
 import tempfile
+from datetime import datetime, timezone
 from pathlib import Path
 from typing import Any
 from unittest.mock import MagicMock, patch
@@ -28,6 +29,10 @@
 # ── Helpers ───────────────────────────────────────────────────────────────────
 
 
+def _recent_generated_at() -> str:
+    return datetime.now(timezone.utc).isoformat()
+
+
 def _make_repo(name: str = "my-repo", **kwargs: Any) -> dict:
     return {
         "repo_name": name,
@@ -531,12 +536,13 @@ def test_boot_no_truth_file_exits_cleanly(self) -> None:
 
 def _make_approved_packet(
     goal: str = "archive dead repos",
-    generated_at: str = "2026-05-11T00:00:00+00:00",
+    generated_at: str | None = None,
     status: str = "approved-manual",
 ) -> tuple[CampaignPlanPacket, dict]:
     """Return a (packet, ledger_record) pair for test setup."""
     from src.plan_campaign import _goal_subject_key, _packet_record_id
 
+    generated_at = generated_at or _recent_generated_at()
     actions = [
         CampaignAction(
             repo_name="old-repo",
@@ -612,7 +618,7 @@ def test_skips_packets_older_than_30_days(self) -> None:
         with tempfile.TemporaryDirectory() as tmp:
             output_dir = Path(tmp)
             _, fresh_record = _make_approved_packet(
-                "fresh goal", generated_at="2026-05-11T00:00:00+00:00"
+                "fresh goal", generated_at=_recent_generated_at()
             )
             _, stale_record = _make_approved_packet(
                 "stale goal", generated_at="2026-01-01T00:00:00+00:00"