codex/chore/ruff base config#73
Conversation
saagpatel
commented
Jun 19, 2026
saagpatel
commented
- chore: extend ruff config from portfolio base
- fix(release): use os.path.expanduser in test fixture instead of hardcoded path
Switches [tool.ruff] to extend from ~/Projects/ruff.toml which holds the shared baseline (line-length=100, select=E/F/I/UP). Per-repo extras kept via extend-select; target-version stays local.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6ebdca60f7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| [tool.ruff] | ||
| target-version = "py311" | ||
| line-length = 100 | ||
| extend = "../ruff.toml" |
There was a problem hiding this comment.
In a clean checkout of this repo, the parent file targeted here is absent, while the CI workflow runs ruff check src/ tests/ in .github/workflows/ci.yml:31. Ruff's config extend help describes this as a local config file that is loaded before the current one; with this line, ruff check . exits before linting with Failed to load extended configuration /workspace/ruff.toml. This will fail lint for any clone that does not happen to have that parent-level file, so keep the base config in the repo or point at an existing checked-in file.
Useful? React with 👍 / 👎.
1 participant
