Fix broken test:typings due to parent node_modules node types.#84
Conversation
test:typings was broken due to the test checking the types of `../../node_modules/@types/node/ts4.8`. Force typeRoots to be the local `node_modules` to fix it. Also bump the test dependencies to bunshi 2.1.5.
|
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes the test:typings command that was failing due to TypeScript compiler errors in the parent node_modules Node.js type definitions. The fix involves configuring TypeScript to use only local type definitions to avoid conflicts with incompatible type definitions in the parent directory.
- Force TypeScript to use only local
node_modules/@typesfor type resolution - Update bunshi dependency to version 2.1.5
Files not reviewed (1)
- examples/old-typescript/package-lock.json: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Description of the change
Edit : see #91 for a better fix using pnpm.
test:typingswas broken due to the test checking the types of../../node_modules/@types/node/ts4.8. Force typeRoots to be the localnode_modulesto fix it. Also bump the test dependencies to bunshi 2.1.5.Show error log
Type of change