Skip to content

Update eslint to 9 and add jsdoc plugin#92

Open
Wendy Fouchter (Wendystraite) wants to merge 1 commit into
saasquatch:mainfrom
Wendystraite:update_eslint
Open

Update eslint to 9 and add jsdoc plugin#92
Wendy Fouchter (Wendystraite) wants to merge 1 commit into
saasquatch:mainfrom
Wendystraite:update_eslint

Conversation

@Wendystraite
Copy link
Copy Markdown
Contributor

Description of the change

  • Update eslint from 8 to 9.
  • Migrate the old config to the new eslint flat configs
  • Add eslint-plugin-jsdoc to check jsdoc validity and prevent false positives of "no-unused-vars" when importing a type only for jsdoc.
  • Fix all new errors and warnings
  • Fix "ComponentScope.test.tsx" that didn't check for React strict mode

See https://eslint.org/docs/latest/use/migrate-to-9.0.0

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation or Development tools (readme, specs, tests, code formatting)

Copilot AI review requested due to automatic review settings October 11, 2025 13:32
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Oct 11, 2025

⚠️ No Changeset found

Latest commit: 3ff51dd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates ESLint from version 8 to 9 and migrates to the new flat configuration format. The update also adds the eslint-plugin-jsdoc to improve JSDoc validation and prevent false positives for type imports used only in documentation.

  • Upgrade ESLint to v9 with flat config migration
  • Add JSDoc linting with eslint-plugin-jsdoc
  • Fix all new ESLint errors and warnings across the codebase

Reviewed Changes

Copilot reviewed 27 out of 28 changed files in this pull request and generated 1 comment.

File Description
package.json Update ESLint and TypeScript-ESLint to latest versions, add JSDoc plugin
eslint.config.mjs New flat ESLint configuration replacing .eslintrc.json
.eslintrc.json Remove old ESLint configuration file
Multiple TypeScript files Fix linting errors including variable declarations, type usage, and JSDoc issues

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/vanilla/lifecycle.ts
@loganvolkers
Copy link
Copy Markdown
Member

Wendy Fouchter (@Wendystraite) please update your PR on top of main to resolve merge conflicts.

- Update eslint from 8 to 9.
- Migrate the old config to the new eslint flat configs
- Add eslint-plugin-jsdoc to check jsdoc validity and prevent false positives of "no-unused-vars" when importing a type only for jsdoc.
- Fix all new errors and warnings
- Fix "ComponentScope.test.tsx" that didn't check for React strict mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants