fix issues with checkbox field#500
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issues with the <sqm-checkbox-field> registration form integration by exposing the checkbox control outside of Shadow DOM and correcting the logic that marks the checkbox as required when it’s not optional.
Changes:
- Disabled Shadow DOM rendering for
<sqm-checkbox-field>to allow the underlying form control to be discovered/serialized by the parent form. - Fixed the
requiredattribute logic so non-optional checkboxes are actually required. - Corrected a UI label typo (“lext” → “text”) and updated generated typings/changelog text accordingly.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/mint-components/src/components/sqm-checkbox-field/sqm-checkbox-field.tsx | Turns off Shadow DOM for the checkbox field and fixes a doc typo. |
| packages/mint-components/src/components/sqm-checkbox-field/sqm-checkbox-field-view.tsx | Corrects required attribute behavior for non-optional checkboxes. |
| packages/mint-components/src/components.d.ts | Prop docs typo fix propagated into generated typings. |
| packages/mint-components/CHANGELOG.md | Adds a 2.1.12 entry and updates compare/tag links (but version is not bumped in package.json). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Type of change
Links
Checklists
Development
Paperwork
Code review