Skip to content

fix issues with checkbox field #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sam Beveridge (00salmon) merged 5 commits into from
May 25, 2026
Merged

fix issues with checkbox field #500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0328201
fix issues with checkbox field
00salmon May 25, 2026
041abce
Create gold-items-start.md
00salmon May 25, 2026
ba5f8a0
Potential fix for pull request finding
00salmon May 25, 2026
1ec5094
revert for changeset
00salmon May 25, 2026
c886409
Merge branch 'fix-checkbox' of https://github.com/saasquatch/program-…
00salmon May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/mint-components/.changeset/gold-items-start.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@saasquatch/mint-components": patch
---

Fixes issue with the checkbox not properly being set as required in registration forms
Comment thread
00salmon marked this conversation as resolved.
4 changes: 2 additions & 2 deletions packages/mint-components/src/components.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,7 @@ export namespace Components {
*/
"checkboxLabelLink"?: string;
/**
* @uiName Checkbox label link lext
* @uiName Checkbox label link text
*/
"checkboxLabelLinkText"?: string;
/**
Expand Down Expand Up @@ -8556,7 +8556,7 @@ declare namespace LocalJSX {
*/
"checkboxLabelLink"?: string;
/**
* @uiName Checkbox label link lext
* @uiName Checkbox label link text
*/
"checkboxLabelLinkText"?: string;
/**
Expand Down
2 changes: 1 addition & 1 deletion packages/mint-components/src/components/sqm-checkbox-field/sqm-checkbox-field-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ export function CheckboxFieldView(props: CheckboxFieldViewProps) {
e.target.value = e.target.checked;
callbacks.setChecked(e.target.value);
}}
{...(!content.checkboxOptional ? { required: false } : [])}
{...(!content.checkboxOptional ? { required: true } : [])}
disabled={
states.registrationFormState?.loading ||
states.registrationFormState?.disabled
Expand Down
4 changes: 2 additions & 2 deletions packages/mint-components/src/components/sqm-checkbox-field/sqm-checkbox-field.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import { useCheckboxField } from "./useCheckboxField";
*/
@Component({
tag: "sqm-checkbox-field",
shadow: true,
shadow: false,
Comment thread
00salmon marked this conversation as resolved.
Comment thread
00salmon marked this conversation as resolved.
})
export class CheckboxField {
@State()
Expand All @@ -46,7 +46,7 @@ export class CheckboxField {
@Prop() checkboxLabelLink?: string = "https://example.com";

/**
* @uiName Checkbox label link lext
* @uiName Checkbox label link text
*/
@Prop() checkboxLabelLinkText?: string = "Terms and Conditions";

Expand Down
Loading